Skip to content
Browse files

tools/firewire: nosy-dump: check for allocation failure

Behavior of null pointer dereference is undefined in the C language.
Portably implement the desired behavior.

Reported-by: Yang Yeping <yangyeping_666@hotmail.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
  • Loading branch information...
1 parent 9489e9d commit 6fa79bcaecdbb0eb417afbc7fb0a8fa204308b62 Stefan Richter committed Oct 22, 2012
Showing with 4 additions and 0 deletions.
  1. +4 −0 tools/firewire/nosy-dump.c
View
4 tools/firewire/nosy-dump.c
@@ -150,6 +150,8 @@ subaction_create(uint32_t *data, size_t length)
/* we put the ack in the subaction struct for easy access. */
sa = malloc(sizeof *sa - sizeof sa->packet + length);
+ if (!sa)
+ exit(EXIT_FAILURE);
sa->ack = data[length / 4 - 1];
sa->length = length;
memcpy(&sa->packet, data, length);
@@ -180,6 +182,8 @@ link_transaction_lookup(int request_node, int response_node, int tlabel)
}
t = malloc(sizeof *t);
+ if (!t)
+ exit(EXIT_FAILURE);
t->request_node = request_node;
t->response_node = response_node;
t->tlabel = tlabel;

0 comments on commit 6fa79bc

Please sign in to comment.
Something went wrong with that request. Please try again.