Skip to content

Commit 79e4865

Browse files
kengiterdavem330
authored andcommitted
net: fix a kernel infoleak in x25 module
Stack object "dte_facilities" is allocated in x25_rx_call_request(), which is supposed to be initialized in x25_negotiate_facilities. However, 5 fields (8 bytes in total) are not initialized. This object is then copied to userland via copy_to_user, thus infoleak occurs. Signed-off-by: Kangjie Lu <kjlu@gatech.edu> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 7fa816b commit 79e4865

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Diff for: net/x25/x25_facilities.c

+1
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,7 @@ int x25_negotiate_facilities(struct sk_buff *skb, struct sock *sk,
277277

278278
memset(&theirs, 0, sizeof(theirs));
279279
memcpy(new, ours, sizeof(*new));
280+
memset(dte, 0, sizeof(*dte));
280281

281282
len = x25_parse_facilities(skb, &theirs, dte, &x25->vc_facil_mask);
282283
if (len < 0)

0 commit comments

Comments
 (0)