Browse files

xfs: don't fail when converting shortform attr to long form during AT…


Kanda Motohiro reported that expanding a tiny xattr into a large xattr
fails on XFS because we remove the tiny xattr from a shortform fork and
then try to re-add it after converting the fork to extents format having
not removed the ATTR_REPLACE flag.  This fails because the attr is no
longer present, causing a fs shutdown.

This is derived from the patch in his bug report, but we really
shouldn't ignore a nonzero retval from the remove call.

Reviewed-by: Dave Chinner <>
Reviewed-by: Christoph Hellwig <>
Signed-off-by: Darrick J. Wong <>
  • Loading branch information...
djwong committed Apr 18, 2018
1 parent 7d83fb1 commit 7b38460dc8e4eafba06c78f8e37099d3b34d473c
Showing with 8 additions and 1 deletion.
  1. +8 −1 fs/xfs/libxfs/xfs_attr.c
@@ -511,7 +511,14 @@ xfs_attr_shortform_addname(xfs_da_args_t *args)
if (args->flags & ATTR_CREATE)
return retval;
retval = xfs_attr_shortform_remove(args);
ASSERT(retval == 0);
if (retval)
return retval;
* Since we have removed the old attr, clear ATTR_REPLACE so
* that the leaf format add routine won't trip over the attr
* not being around.
args->flags &= ~ATTR_REPLACE;
if (args->namelen >= XFS_ATTR_SF_ENTSIZE_MAX ||

0 comments on commit 7b38460

Please sign in to comment.