Skip to content

Commit

Permalink
[Cardman 40x0] Fix udev device creation
Browse files Browse the repository at this point in the history
This patch corrects the order of the calls to register_chrdev() and
pcmcia_register_driver().  Now udev correctly creates userspace device
files /dev/cmmN and /dev/cmxN respectively.

Based on an earlier patch by Jan Niehusmann <jan@gondor.com>.

Signed-off-by: Harald Welte <laforge@netfilter.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
laf0rge authored and Linus Torvalds committed May 10, 2006
1 parent 3cd73ee commit 7fc5b1e
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 8 deletions.
10 changes: 6 additions & 4 deletions drivers/char/pcmcia/cm4000_cs.c
Expand Up @@ -1981,17 +1981,19 @@ static int __init cmm_init(void)
if (!cmm_class)
return -1;

rc = pcmcia_register_driver(&cm4000_driver);
if (rc < 0)
return rc;

major = register_chrdev(0, DEVICE_NAME, &cm4000_fops);
if (major < 0) {
printk(KERN_WARNING MODULE_NAME
": could not get major number\n");
return -1;
}

rc = pcmcia_register_driver(&cm4000_driver);
if (rc < 0) {
unregister_chrdev(major, DEVICE_NAME);
return rc;
}

return 0;
}

Expand Down
11 changes: 7 additions & 4 deletions drivers/char/pcmcia/cm4040_cs.c
Expand Up @@ -724,16 +724,19 @@ static int __init cm4040_init(void)
if (!cmx_class)
return -1;

rc = pcmcia_register_driver(&reader_driver);
if (rc < 0)
return rc;

major = register_chrdev(0, DEVICE_NAME, &reader_fops);
if (major < 0) {
printk(KERN_WARNING MODULE_NAME
": could not get major number\n");
return -1;
}

rc = pcmcia_register_driver(&reader_driver);
if (rc < 0) {
unregister_chrdev(major, DEVICE_NAME);
return rc;
}

return 0;
}

Expand Down

0 comments on commit 7fc5b1e

Please sign in to comment.