Skip to content
Browse files

net: fix incorrect credentials passing

Commit 257b535 ("scm: Capture the full credentials of the scm
sender") changed the credentials passing code to pass in the effective
uid/gid instead of the real uid/gid.

Obviously this doesn't matter most of the time (since normally they are
the same), but it results in differences for suid binaries when the wrong
uid/gid ends up being used.

This just undoes that (presumably unintentional) part of the commit.

Reported-by: Andy Lutomirski <>
Cc: Eric W. Biederman <>
Cc: Serge E. Hallyn <>
Cc: David S. Miller <>
Signed-off-by: Linus Torvalds <>
Acked-by: "Eric W. Biederman" <>
Signed-off-by: David S. Miller <>
  • Loading branch information...
torvalds authored and davem330 committed Apr 19, 2013
1 parent c846ad9 commit 83f1b4ba917db5dc5a061a44b3403ddb6e783494
Showing with 2 additions and 2 deletions.
  1. +2 −2 include/net/scm.h
@@ -56,8 +56,8 @@ static __inline__ void scm_set_cred(struct scm_cookie *scm,
scm->pid = get_pid(pid);
scm->cred = cred ? get_cred(cred) : NULL;
scm-> = pid_vnr(pid);
scm->creds.uid = cred ? cred->euid : INVALID_UID;
scm->creds.gid = cred ? cred->egid : INVALID_GID;
scm->creds.uid = cred ? cred->uid : INVALID_UID;
scm->creds.gid = cred ? cred->gid : INVALID_GID;

static __inline__ void scm_destroy_cred(struct scm_cookie *scm)

0 comments on commit 83f1b4b

Please sign in to comment.
You can’t perform that action at this time.