Permalink
Browse files

jfs: set i_ctime when setting ACL

This fixes a regression in 3.14-rc1 where xfstests generic/307 fails.

jfs sets the ctime on the inode when writing an xattr. Previously,
jfs went ahead and stored an acl that can be completely represented
in the traditional permission bits, so the ctime was always set in
the xattr code. The new code doesn't bother storing the acl in that
case, thus the ctime isn't getting set.

Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Reported-by: Michael L. Semon <mlsemon35@gmail.com>
  • Loading branch information...
kleikamp committed Feb 13, 2014
1 parent c18f7b5 commit 844fa1b5f8493cff4b976fa7a5b9ebeeafdd75cc
Showing with 2 additions and 0 deletions.
  1. +2 −0 fs/jfs/acl.c
View
@@ -86,6 +86,8 @@ static int __jfs_set_acl(tid_t tid, struct inode *inode, int type,
rc = posix_acl_equiv_mode(acl, &inode->i_mode);
if (rc < 0)
return rc;
+ inode->i_ctime = CURRENT_TIME;
+ mark_inode_dirty(inode);
if (rc == 0)
acl = NULL;
break;

0 comments on commit 844fa1b

Please sign in to comment.