Skip to content

Commit 84d73cd

Browse files
miniplidavem330
authored andcommitted
rtnl: fix info leak on RTM_GETLINK request for VF devices
Initialize the mac address buffer with 0 as the driver specific function will probably not fill the whole buffer. In fact, all in-kernel drivers fill only ETH_ALEN of the MAX_ADDR_LEN bytes, i.e. 6 of the 32 possible bytes. Therefore we currently leak 26 bytes of stack memory to userland via the netlink interface. Signed-off-by: Mathias Krause <minipli@googlemail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent c085c49 commit 84d73cd

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Diff for: net/core/rtnetlink.c

+1
Original file line numberDiff line numberDiff line change
@@ -979,6 +979,7 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb, struct net_device *dev,
979979
* report anything.
980980
*/
981981
ivi.spoofchk = -1;
982+
memset(ivi.mac, 0, sizeof(ivi.mac));
982983
if (dev->netdev_ops->ndo_get_vf_config(dev, i, &ivi))
983984
break;
984985
vf_mac.vf =

0 commit comments

Comments
 (0)