Skip to content

Commit 853acf7

Browse files
NavidemKalle Valo
authored and
Kalle Valo
committed
ath9k_htc: release allocated buffer if timed out
In htc_config_pipe_credits, htc_setup_complete, and htc_connect_service if time out happens, the allocated buffer needs to be released. Otherwise there will be memory leak. Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
1 parent 45f09a1 commit 853acf7

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

Diff for: drivers/net/wireless/ath/ath9k/htc_hst.c

+3
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ static int htc_config_pipe_credits(struct htc_target *target)
170170
time_left = wait_for_completion_timeout(&target->cmd_wait, HZ);
171171
if (!time_left) {
172172
dev_err(target->dev, "HTC credit config timeout\n");
173+
kfree_skb(skb);
173174
return -ETIMEDOUT;
174175
}
175176

@@ -205,6 +206,7 @@ static int htc_setup_complete(struct htc_target *target)
205206
time_left = wait_for_completion_timeout(&target->cmd_wait, HZ);
206207
if (!time_left) {
207208
dev_err(target->dev, "HTC start timeout\n");
209+
kfree_skb(skb);
208210
return -ETIMEDOUT;
209211
}
210212

@@ -277,6 +279,7 @@ int htc_connect_service(struct htc_target *target,
277279
if (!time_left) {
278280
dev_err(target->dev, "Service connection timeout for: %d\n",
279281
service_connreq->service_id);
282+
kfree_skb(skb);
280283
return -ETIMEDOUT;
281284
}
282285

0 commit comments

Comments
 (0)