Browse files

ipv4/ip_gre: set transport header correctly to gre header

ipgre_tunnel_xmit() incorrectly sets transport header to inner payload
instead of GRE header. It seems copy-and-pasted from ipip.c.
So set transport header to gre header.
(In ipip case the transport header is the inner ip header, so that's

Found by inspection. In practice the incorrect transport header
doesn't matter because the skb usually is sent to another net_device
or socket, so the transport header isn't referenced.

Signed-off-by: Isaku Yamahata <>
Signed-off-by: David S. Miller <>
  • Loading branch information...
1 parent a496759 commit 861aa6d56de8147249c8a04a4e87fb7c3600cca1 @yamahata yamahata committed with davem330 Dec 24, 2012
Showing with 1 addition and 1 deletion.
  1. +1 −1 net/ipv4/ip_gre.c
@@ -912,9 +912,9 @@ static netdev_tx_t ipgre_tunnel_xmit(struct sk_buff *skb, struct net_device *dev
/* Warning : tiph value might point to freed memory */
- skb_reset_transport_header(skb);
skb_push(skb, gre_hlen);
+ skb_set_transport_header(skb, sizeof(*iph));
memset(&(IPCB(skb)->opt), 0, sizeof(IPCB(skb)->opt));

0 comments on commit 861aa6d

Please sign in to comment.