Permalink
Browse files

hamradio/yam: fix info leak in ioctl

The yam_ioctl() code fails to initialise the cmd field
of the struct yamdrv_ioctl_cfg. Add an explicit memset(0)
before filling the structure to avoid the 4-byte info leak.

Signed-off-by: Salva Peiró <speiro@ai2.upv.es>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information...
1 parent e9db5c2 commit 8e3fbf870481eb53b2d3a322d1fc395ad8b367ed Salva Peiró committed with davem330 Dec 17, 2013
Showing with 1 addition and 0 deletions.
  1. +1 −0 drivers/net/hamradio/yam.c
@@ -1057,6 +1057,7 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
break;
case SIOCYAMGCFG:
+ memset(&yi, 0, sizeof(yi));
yi.cfg.mask = 0xffffffff;
yi.cfg.iobase = yp->iobase;
yi.cfg.irq = yp->irq;

0 comments on commit 8e3fbf8

Please sign in to comment.