Skip to content

Commit 9ad2de4

Browse files
miniplidavem330
authored andcommitted
Bluetooth: RFCOMM - Fix info leak in getsockopt(BT_SECURITY)
The RFCOMM code fails to initialize the key_size member of struct bt_security before copying it to userland -- that for leaking one byte kernel stack. Initialize key_size with 0 to avoid the info leak. Signed-off-by: Mathias Krause <minipli@googlemail.com> Cc: Marcel Holtmann <marcel@holtmann.org> Cc: Gustavo Padovan <gustavo@padovan.org> Cc: Johan Hedberg <johan.hedberg@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 3f68ba0 commit 9ad2de4

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Diff for: net/bluetooth/rfcomm/sock.c

+1
Original file line numberDiff line numberDiff line change
@@ -822,6 +822,7 @@ static int rfcomm_sock_getsockopt(struct socket *sock, int level, int optname, c
822822
}
823823

824824
sec.level = rfcomm_pi(sk)->sec_level;
825+
sec.key_size = 0;
825826

826827
len = min_t(unsigned int, len, sizeof(sec));
827828
if (copy_to_user(optval, (char *) &sec, len))

0 commit comments

Comments
 (0)