Skip to content

Commit

Permalink
atm: update msg_namelen in vcc_recvmsg()
Browse files Browse the repository at this point in the history
The current code does not fill the msg_name member in case it is set.
It also does not set the msg_namelen member to 0 and therefore makes
net/socket.c leak the local, uninitialized sockaddr_storage variable
to userland -- 128 bytes of kernel stack memory.

Fix that by simply setting msg_namelen to 0 as obviously nobody cared
about vcc_recvmsg() not filling the msg_name in case it was set.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
minipli authored and davem330 committed Apr 7, 2013
1 parent 50a75a8 commit 9b3e617
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions net/atm/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,8 @@ int vcc_recvmsg(struct kiocb *iocb, struct socket *sock, struct msghdr *msg,
struct sk_buff *skb;
int copied, error = -EINVAL;

msg->msg_namelen = 0;

if (sock->state != SS_CONNECTED)
return -ENOTCONN;

Expand Down

0 comments on commit 9b3e617

Please sign in to comment.