Skip to content

Commit 9b3e617

Browse files
miniplidavem330
authored andcommitted
atm: update msg_namelen in vcc_recvmsg()
The current code does not fill the msg_name member in case it is set. It also does not set the msg_namelen member to 0 and therefore makes net/socket.c leak the local, uninitialized sockaddr_storage variable to userland -- 128 bytes of kernel stack memory. Fix that by simply setting msg_namelen to 0 as obviously nobody cared about vcc_recvmsg() not filling the msg_name in case it was set. Signed-off-by: Mathias Krause <minipli@googlemail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 50a75a8 commit 9b3e617

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Diff for: net/atm/common.c

+2
Original file line numberDiff line numberDiff line change
@@ -531,6 +531,8 @@ int vcc_recvmsg(struct kiocb *iocb, struct socket *sock, struct msghdr *msg,
531531
struct sk_buff *skb;
532532
int copied, error = -EINVAL;
533533

534+
msg->msg_namelen = 0;
535+
534536
if (sock->state != SS_CONNECTED)
535537
return -ENOTCONN;
536538

0 commit comments

Comments
 (0)