Permalink
Browse files
spi-nor: intel-spi: Fix broken software sequencing codes
There are two bugs in current intel_spi_sw_cycle(): - The 'data byte count' field should be the number of bytes transferred minus 1 - SSFSTS_CTL is the offset from ispi->sregs, not ispi->base Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Cc: <stable@vger.kernel.org> # v4.11+ Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
- Loading branch information...
James Courtier-Dutton noted
lenis not being validated, particularly against being zero.It should probably at a minimum have
HSFSTS_CTL_FDBC_MASKapplied after the shift, and preferable validating thatlenis within the allowed range (1..64?).