Skip to content
Permalink
Browse files

Bluetooth: hidp: fix buffer overflow

Struct ca is copied from userspace. It is not checked whether the "name"
field is NULL terminated, which allows local users to obtain potentially
sensitive information from kernel stack memory, via a HIDPCONNADD command.

This vulnerability is similar to CVE-2011-1079.

Signed-off-by: Young Xiao <YangX92@hotmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Cc: stable@vger.kernel.org
  • Loading branch information...
Young Xiao authored and holtmann committed Apr 12, 2019
1 parent 7362334 commit a1616a5ac99ede5d605047a9012481ce7ff18b16
Showing with 1 addition and 0 deletions.
  1. +1 −0 net/bluetooth/hidp/sock.c
@@ -75,6 +75,7 @@ static int do_hidp_sock_ioctl(struct socket *sock, unsigned int cmd, void __user
sockfd_put(csock);
return err;
}
ca.name[sizeof(ca.name)-1] = 0;

err = hidp_connection_add(&ca, csock, isock);
if (!err && copy_to_user(argp, &ca, sizeof(ca)))

0 comments on commit a1616a5

Please sign in to comment.
You can’t perform that action at this time.