Browse files

ipv6/ip6_gre: set transport header correctly

ip6gre_xmit2() incorrectly sets transport header to inner payload
instead of GRE header. It seems copy-and-pasted from ipip.c.
Set transport header to gre header.
(In ipip case the transport header is the inner ip header, so that's

Found by inspection. In practice the incorrect transport header
doesn't matter because the skb usually is sent to another net_device
or socket, so the transport header isn't referenced.

Signed-off-by: Isaku Yamahata <>
Signed-off-by: David S. Miller <>
  • Loading branch information...
1 parent 861aa6d commit ae782bb16c35ce27512beeda9be6024c88f85b08 @yamahata yamahata committed with davem330 Dec 24, 2012
Showing with 1 addition and 2 deletions.
  1. +1 −2 net/ipv6/ip6_gre.c
@@ -758,8 +758,6 @@ static netdev_tx_t ip6gre_xmit2(struct sk_buff *skb,
skb_dst_set_noref(skb, dst);
- skb->transport_header = skb->network_header;
proto = NEXTHDR_GRE;
if (encap_limit >= 0) {
init_tel_txopt(&opt, encap_limit);
@@ -768,6 +766,7 @@ static netdev_tx_t ip6gre_xmit2(struct sk_buff *skb,
skb_push(skb, gre_hlen);
+ skb_set_transport_header(skb, sizeof(*ipv6h));
* Push down and install the IP header.

0 comments on commit ae782bb

Please sign in to comment.