Skip to content
Browse files

net: fib: fib6_add: fix potential NULL pointer dereference

When the kernel is compiled with CONFIG_IPV6_SUBTREES, and we return
with an error in fn = fib6_add_1(), then error codes are encoded into
the return pointer e.g. ERR_PTR(-ENOENT). In such an error case, we
write the error code into err and jump to out, hence enter the if(err)
condition. Now, if CONFIG_IPV6_SUBTREES is enabled, we check for:

  if (pn != fn && pn->leaf == rt)
  if (pn != fn && !pn->leaf && !(pn->fn_flags & RTN_RTINFO))

Since pn is NULL and fn is f.e. ERR_PTR(-ENOENT), then pn != fn
evaluates to true and causes a NULL-pointer dereference on further
checks on pn. Fix it, by setting both NULL in error case, so that
pn != fn already evaluates to false and no further dereference
takes place.

This was first correctly implemented in 4a287eb ("IPv6 routing,
NLM_F_* flag support: REPLACE and EXCL flags support, warn about
missing CREATE flag"), but the bug got later on introduced by
188c517 ("ipv6: return errno pointers consistently for fib6_add_1()").

Signed-off-by: Daniel Borkmann <>
Cc: Lin Ming <>
Cc: Matti Vaittinen <>
Cc: Hannes Frederic Sowa <>
Acked-by: Hannes Frederic Sowa <>
Acked-by: Matti Vaittinen <>
Signed-off-by: David S. Miller <>
  • Loading branch information...
borkmann authored and davem330 committed Sep 7, 2013
1 parent 3bf4b5b commit ae7b4e1f213aa659aedf9c6ecad0bf5f0476e1e2
Showing with 1 addition and 1 deletion.
  1. +1 −1 net/ipv6/ip6_fib.c
@@ -825,9 +825,9 @@ int fib6_add(struct fib6_node *root, struct rt6_info *rt, struct nl_info *info)
fn = fib6_add_1(root, &rt->rt6i_dst.addr, rt->rt6i_dst.plen,
offsetof(struct rt6_info, rt6i_dst), allow_create,

if (IS_ERR(fn)) {
err = PTR_ERR(fn);
fn = NULL;
goto out;

0 comments on commit ae7b4e1

Please sign in to comment.
You can’t perform that action at this time.