Skip to content
Browse files

ALSA: hda/idt - Fix power-map for speaker-pins with some HP laptops

BIOS on some HP laptops don't set the speaker-pins as fixed but expose
as jacks, and this confuses the driver as if these pins are
jack-detectable.  As a result, the machine doesn't get sounds from
speakers because the driver prepares the power-map update via jack
unsol events which never come up in reality.  The bug was introduced
in some time in 3.2 for enabling the power-mapping feature.

This patch fixes the problem by replacing the check of the persistent
power-map bits with a proper is_jack_detectable() call.


Cc: <> [v3.2+]
Signed-off-by: Takashi Iwai <>
  • Loading branch information...
1 parent 9ea3356 commit b0791dda813c179e539b0fc1ecd3f5f30f2571e2 @tiwai tiwai committed May 15, 2012
Showing with 3 additions and 3 deletions.
  1. +3 −3 sound/pci/hda/patch_sigmatel.c
6 sound/pci/hda/patch_sigmatel.c
@@ -4415,9 +4415,9 @@ static int stac92xx_init(struct hda_codec *codec)
def_conf = get_defcfg_connect(def_conf);
/* skip any ports that don't have jacks since presence
* detection is useless */
- if (def_conf != AC_JACK_PORT_COMPLEX) {
- if (def_conf != AC_JACK_PORT_NONE)
- stac_toggle_power_map(codec, nid, 1);
+ if (def_conf != AC_JACK_PORT_NONE &&
+ !is_jack_detectable(codec, nid)) {
+ stac_toggle_power_map(codec, nid, 1);
if (enable_pin_detect(codec, nid, STAC_PWR_EVENT)) {

0 comments on commit b0791dd

Please sign in to comment.
Something went wrong with that request. Please try again.