Skip to content

Commit b6878d9

Browse files
benjamin-42NeilBrown
authored and
NeilBrown
committed
md: use kzalloc() when bitmap is disabled
In drivers/md/md.c get_bitmap_file() uses kmalloc() for creating a mdu_bitmap_file_t called "file". 5769 file = kmalloc(sizeof(*file), GFP_NOIO); 5770 if (!file) 5771 return -ENOMEM; This structure is copied to user space at the end of the function. 5786 if (err == 0 && 5787 copy_to_user(arg, file, sizeof(*file))) 5788 err = -EFAULT But if bitmap is disabled only the first byte of "file" is initialized with zero, so it's possible to read some bytes (up to 4095) of kernel space memory from user space. This is an information leak. 5775 /* bitmap disabled, zero the first byte and copy out */ 5776 if (!mddev->bitmap_info.file) 5777 file->pathname[0] = '\0'; Signed-off-by: Benjamin Randazzo <benjamin@randazzo.fr> Signed-off-by: NeilBrown <neilb@suse.com>
1 parent 423f04d commit b6878d9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: drivers/md/md.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -5759,7 +5759,7 @@ static int get_bitmap_file(struct mddev *mddev, void __user * arg)
57595759
char *ptr;
57605760
int err;
57615761

5762-
file = kmalloc(sizeof(*file), GFP_NOIO);
5762+
file = kzalloc(sizeof(*file), GFP_NOIO);
57635763
if (!file)
57645764
return -ENOMEM;
57655765

0 commit comments

Comments
 (0)