Please sign in to comment.
ptrace,x86: force IRET path after a ptrace_stop()
The 'sysret' fastpath does not correctly restore even all regular registers, much less any segment registers or reflags values. That is very much part of why it's faster than 'iret'. Normally that isn't a problem, because the normal ptrace() interface catches the process using the signal handler infrastructure, which always returns with an iret. However, some paths can get caught using ptrace_event() instead of the signal path, and for those we need to make sure that we aren't going to return to user space using 'sysret'. Otherwise the modifications that may have been done to the register set by the tracer wouldn't necessarily take effect. Fix it by forcing IRET path by setting TIF_NOTIFY_RESUME from arch_ptrace_stop_needed() which is invoked from ptrace_stop(). Signed-off-by: Tejun Heo <firstname.lastname@example.org> Reported-by: Andy Lutomirski <email@example.com> Acked-by: Oleg Nesterov <firstname.lastname@example.org> Suggested-by: Linus Torvalds <email@example.com> Cc: firstname.lastname@example.org Signed-off-by: Linus Torvalds <email@example.com>
- Loading branch information...
Showing with 19 additions and 0 deletions.