Skip to content
Browse files

tcp: avoid infinite loop in tcp_splice_read()

Splicing from TCP socket is vulnerable when a packet with URG flag is
received and stored into receive queue.

__tcp_splice_read() returns 0, and sk_wait_data() immediately
returns since there is the problematic skb in queue.

This is a nice way to burn cpu (aka infinite loop) and trigger
soft lockups.

Again, this gem was found by syzkaller tool.

Fixes: 9c55e01 ("[TCP]: Splice receive support.")
Signed-off-by: Eric Dumazet <>
Reported-by: Dmitry Vyukov  <>
Cc: Willy Tarreau <>
Signed-off-by: David S. Miller <>
  • Loading branch information...
Eric Dumazet authored and davem330 committed Feb 3, 2017
1 parent b3f2d07 commit ccf7abb93af09ad0868ae9033d1ca8108bdaec82
Showing with 6 additions and 0 deletions.
  1. +6 −0 net/ipv4/tcp.c
@@ -770,6 +770,12 @@ ssize_t tcp_splice_read(struct socket *sock, loff_t *ppos,
ret = -EAGAIN;
/* if __tcp_splice_read() got nothing while we have
* an skb in receive queue, we do not want to loop.
* This might happen with URG data.
if (!skb_queue_empty(&sk->sk_receive_queue))
sk_wait_data(sk, &timeo, NULL);
if (signal_pending(current)) {
ret = sock_intr_errno(timeo);

0 comments on commit ccf7abb

Please sign in to comment.
You can’t perform that action at this time.