Skip to content

Commit

Permalink
ALSA: timer: Fix leak in SNDRV_TIMER_IOCTL_PARAMS
Browse files Browse the repository at this point in the history
The stack object “tread” has a total size of 32 bytes. Its field
“event” and “val” both contain 4 bytes padding. These 8 bytes
padding bytes are sent to user without being initialized.

Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
kengiter authored and tiwai committed May 8, 2016
1 parent 242658f commit cec8f96
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions sound/core/timer.c
Original file line number Diff line number Diff line change
Expand Up @@ -1737,6 +1737,7 @@ static int snd_timer_user_params(struct file *file,
if (tu->timeri->flags & SNDRV_TIMER_IFLG_EARLY_EVENT) {
if (tu->tread) {
struct snd_timer_tread tread;
memset(&tread, 0, sizeof(tread));
tread.event = SNDRV_TIMER_EVENT_EARLY;
tread.tstamp.tv_sec = 0;
tread.tstamp.tv_nsec = 0;
Expand Down

0 comments on commit cec8f96

Please sign in to comment.