Skip to content

Commit

Permalink
ALSA: timer: Fix leak in events via snd_timer_user_tinterrupt
Browse files Browse the repository at this point in the history
The stack object “r1” has a total size of 32 bytes. Its field
“event” and “val” both contain 4 bytes padding. These 8 bytes
padding bytes are sent to user without being initialized.

Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
kengiter authored and tiwai committed May 8, 2016
1 parent 9a47e9c commit e4ec8cc
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions sound/core/timer.c
Original file line number Diff line number Diff line change
Expand Up @@ -1266,6 +1266,7 @@ static void snd_timer_user_tinterrupt(struct snd_timer_instance *timeri,
}
if ((tu->filter & (1 << SNDRV_TIMER_EVENT_RESOLUTION)) &&
tu->last_resolution != resolution) {
memset(&r1, 0, sizeof(r1));
r1.event = SNDRV_TIMER_EVENT_RESOLUTION;
r1.tstamp = tstamp;
r1.val = resolution;
Expand Down

0 comments on commit e4ec8cc

Please sign in to comment.