Browse files

debugfs: convert gid= argument from decimal, not octal

This patch technically breaks userspace, but I suspect that anyone who
actually used this flag would have encountered this brokenness, declared
it lunacy, and already sent a patch.

Signed-off-by: Dave Reisner <>
Reviewed-by: Vasiliy Kulikov <>
Acked-by: Kees Cook <>
Signed-off-by: Greg Kroah-Hartman <>
  • Loading branch information...
falconindy authored and gregkh committed Jan 2, 2013
1 parent 54b956b commit f1688e0431d3a395388e70fe21da89ed0de0c323
Showing with 1 addition and 1 deletion.
  1. +1 −1 fs/debugfs/inode.c
@@ -176,7 +176,7 @@ static int debugfs_parse_options(char *data, struct debugfs_mount_opts *opts)
opts->uid = uid;
case Opt_gid:
- if (match_octal(&args[0], &option))
+ if (match_int(&args[0], &option))
return -EINVAL;
gid = make_kgid(current_user_ns(), option);
if (!gid_valid(gid))

0 comments on commit f1688e0

Please sign in to comment.