Permalink
Browse files

task_work: add a scheduling point in task_work_run()

It seems commit 4a9d4b0 ("switch fput to task_work_add") re-
introduced the problem addressed in 944be0b ("close_files(): add
scheduling point")

If a server process with a lot of files (say 2 million tcp sockets) is
killed, we can spend a lot of time in task_work_run() and trigger a soft
lockup.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information...
1 parent ec5da7f commit f341861fb0b701139849f8a85c2d3cdff466e8e8 Eric Dumazet committed with Aug 21, 2012
Showing with 1 addition and 0 deletions.
  1. +1 −0 kernel/task_work.c
View
@@ -75,6 +75,7 @@ void task_work_run(void)
p = q->next;
q->func(q);
q = p;
+ cond_resched();
}
}
}

0 comments on commit f341861

Please sign in to comment.