Skip to content

Commit f84598b

Browse files
Quentin Casasnovassuryasaimadhu
Quentin Casasnovas
authored andcommitted
x86/microcode/intel: Guard against stack overflow in the loader
mc_saved_tmp is a static array allocated on the stack, we need to make sure mc_saved_count stays within its bounds, otherwise we're overflowing the stack in _save_mc(). A specially crafted microcode header could lead to a kernel crash or potentially kernel execution. Signed-off-by: Quentin Casasnovas <quentin.casasnovas@oracle.com> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: Fenghua Yu <fenghua.yu@intel.com> Link: http://lkml.kernel.org/r/1422964824-22056-1-git-send-email-quentin.casasnovas@oracle.com Signed-off-by: Borislav Petkov <bp@suse.de>
1 parent e36f014 commit f84598b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: arch/x86/kernel/cpu/microcode/intel_early.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ get_matching_model_microcode(int cpu, unsigned long start,
321321
unsigned int mc_saved_count = mc_saved_data->mc_saved_count;
322322
int i;
323323

324-
while (leftover) {
324+
while (leftover && mc_saved_count < ARRAY_SIZE(mc_saved_tmp)) {
325325
mc_header = (struct microcode_header_intel *)ucode_ptr;
326326

327327
mc_size = get_totalsize(mc_header);

0 commit comments

Comments
 (0)