Skip to content
Permalink
Browse files Browse the repository at this point in the history
usb: dwc3: dwc3-qcom: Add missing platform_device_put() in dwc3_qcom_…
…acpi_register_core

Add the missing platform_device_put() before return from
dwc3_qcom_acpi_register_core in the error handling case.

Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20211231113641.31474-1-linmq006@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Yuuoniy authored and gregkh committed Jan 3, 2022
1 parent 501e38a commit fa0ef93
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion drivers/usb/dwc3/dwc3-qcom.c
Expand Up @@ -598,8 +598,10 @@ static int dwc3_qcom_acpi_register_core(struct platform_device *pdev)
qcom->dwc3->dev.coherent_dma_mask = dev->coherent_dma_mask;

child_res = kcalloc(2, sizeof(*child_res), GFP_KERNEL);
if (!child_res)
if (!child_res) {
platform_device_put(qcom->dwc3);
return -ENOMEM;
}

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res) {
Expand Down Expand Up @@ -637,9 +639,13 @@ static int dwc3_qcom_acpi_register_core(struct platform_device *pdev)
if (ret) {
dev_err(&pdev->dev, "failed to add device\n");
device_remove_software_node(&qcom->dwc3->dev);
goto out;
}
kfree(child_res);
return 0;

out:
platform_device_put(qcom->dwc3);
kfree(child_res);
return ret;
}
Expand Down

0 comments on commit fa0ef93

Please sign in to comment.