Skip to content

Commit fbe0e83

Browse files
LiJinyueKAGA-KOKO
authored andcommitted
futex: Prevent overflow by strengthen input validation
UBSAN reports signed integer overflow in kernel/futex.c: UBSAN: Undefined behaviour in kernel/futex.c:2041:18 signed integer overflow: 0 - -2147483648 cannot be represented in type 'int' Add a sanity check to catch negative values of nr_wake and nr_requeue. Signed-off-by: Li Jinyue <lijinyue@huawei.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: peterz@infradead.org Cc: dvhart@infradead.org Cc: stable@vger.kernel.org Link: https://lkml.kernel.org/r/1513242294-31786-1-git-send-email-lijinyue@huawei.com
1 parent c1e2f0e commit fbe0e83

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

Diff for: kernel/futex.c

+3
Original file line numberDiff line numberDiff line change
@@ -1878,6 +1878,9 @@ static int futex_requeue(u32 __user *uaddr1, unsigned int flags,
18781878
struct futex_q *this, *next;
18791879
DEFINE_WAKE_Q(wake_q);
18801880

1881+
if (nr_wake < 0 || nr_requeue < 0)
1882+
return -EINVAL;
1883+
18811884
/*
18821885
* When PI not supported: return -ENOSYS if requeue_pi is true,
18831886
* consequently the compiler knows requeue_pi is always false past

0 commit comments

Comments
 (0)