Please sign in to comment.
bonding: fix bond_get_stats()
bond_get_stats() can be called from rtnetlink (with RTNL held) or from /proc/net/dev seq handler (with RCU held) The logic added in commit 5f0c5f7 ("bonding: make global bonding stats more reliable") kind of assumed only one cpu could run there. If multiple threads are reading /proc/net/dev, stats can be really messed up after a while. A second problem is that some fields are 32bit, so we need to properly handle the wrap around problem. Given that RTNL is not always held, we need to use bond_for_each_slave_rcu(). Fixes: 5f0c5f7 ("bonding: make global bonding stats more reliable") Signed-off-by: Eric Dumazet <email@example.com> Cc: Andy Gospodarek <firstname.lastname@example.org> Cc: Jay Vosburgh <email@example.com> Cc: Veaceslav Falico <firstname.lastname@example.org> Reviewed-by: Nikolay Aleksandrov <email@example.com> Signed-off-by: David S. Miller <firstname.lastname@example.org>
- Loading branch information...
Showing with 36 additions and 31 deletions.