Skip to content

Commit fe685aa

Browse files
miniplijankara
authored andcommitted
isofs: avoid info leak on export
For type 1 the parent_offset member in struct isofs_fid gets copied uninitialized to userland. Fix this by initializing it to 0. Signed-off-by: Mathias Krause <minipli@googlemail.com> Signed-off-by: Jan Kara <jack@suse.cz>
1 parent 57b9655 commit fe685aa

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Diff for: fs/isofs/export.c

+1
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ isofs_export_encode_fh(struct inode *inode,
134134
len = 3;
135135
fh32[0] = ei->i_iget5_block;
136136
fh16[2] = (__u16)ei->i_iget5_offset; /* fh16 [sic] */
137+
fh16[3] = 0; /* avoid leaking uninitialized data */
137138
fh32[2] = inode->i_generation;
138139
if (parent) {
139140
struct iso_inode_info *eparent;

0 commit comments

Comments
 (0)