Skip to content
Commits on Jun 27, 2012
  1. @herbertx

    crypto: algapi - Fix hang on crypto allocation

    Steffen Klassert committed with herbertx
    git commit 3987103 (crypto: algapi - Move larval completion
    into algboss) replaced accidentally a call to complete_all() by
    a call to complete(). This causes a hang on crypto allocation
    if we have more than one larval waiter. This pach restores the
    call to complete_all().
    Signed-off-by: Steffen Klassert <>
    Signed-off-by: Herbert Xu <>
Commits on Jun 22, 2012
  1. @herbertx

    crypto: algapi - Move larval completion into algboss

    herbertx committed
    It has been observed that sometimes the crypto allocation code
    will get stuck for 60 seconds or multiples thereof.  This is
    usually caused by an algorithm failing to pass the self-test.
    If an algorithm fails to be constructed, we will immediately notify
    all larval waiters.  However, if it succeeds in construction, but
    then fails the self-test, we won't notify anyone at all.
    This patch fixes this by merging the notification in the case
    where the algorithm fails to be constructed with that of the
    the case where it pases the self-test.  This way regardless of
    what happens, we'll give the larval waiters an answer.
    Signed-off-by: Herbert Xu <>
Commits on Aug 6, 2010
  1. @herbertx

    crypto: testmgr - Fix test disabling option

    herbertx committed
    This patch fixes a serious bug in the test disabling patch where
    it can cause an spurious load of the cryptomgr module even when
    it's compiled in.
    It also negates the test disabling option so that its absence
    causes tests to be enabled.
    The Kconfig option is also now behind EMBEDDED.
    Signed-off-by: Herbert Xu <>
Commits on Jun 3, 2010
  1. @virtuoso @herbertx

    crypto: testmgr - add an option to disable cryptoalgos' self-tests

    virtuoso committed with herbertx
    By default, CONFIG_CRYPTO_MANAGER_TESTS will be enabled and thus
    self-tests will still run, but it is now possible to disable them
    to gain some time during bootup.
    Signed-off-by: Alexander Shishkin <>
    Signed-off-by: Herbert Xu <>
Commits on Mar 30, 2010
  1. include cleanup: Update gfp.h and slab.h includes to prepare for brea…

    Tejun Heo committed
    …king implicit slab.h inclusion from percpu.h
    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files.  percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.
    percpu.h -> slab.h dependency is about to be removed.  Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability.  As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.
    The script does the followings.
    * Scan files for gfp and slab usages and update includes such that
      only the necessary includes are there.  ie. if only gfp is used,
      gfp.h, if slab is used, slab.h.
    * When the script inserts a new include, it looks at the include
      blocks and try to put the new include such that its order conforms
      to its surrounding.  It's put in the include block which contains
      core kernel includes, in the same order that the rest are ordered -
      alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
      doesn't seem to be any matching order.
    * If the script can't find a place to put a new include (mostly
      because the file doesn't have fitting include block), it prints out
      an error message indicating which .h file needs to be added to the
    The conversion was done in the following steps.
    1. The initial automatic conversion of all .c files updated slightly
       over 4000 files, deleting around 700 includes and adding ~480 gfp.h
       and ~3000 slab.h inclusions.  The script emitted errors for ~400
    2. Each error was manually checked.  Some didn't need the inclusion,
       some needed manual addition while adding it to implementation .h or
       embedding .c file was more appropriate for others.  This step added
       inclusions to around 150 files.
    3. The script was run again and the output was compared to the edits
       from #2 to make sure no file was left behind.
    4. Several build tests were done and a couple of problems were fixed.
       e.g. lib/decompress_*.c used malloc/free() wrappers around slab
       APIs requiring slab.h to be added manually.
    5. The script was run on all .h files but without automatically
       editing them as sprinkling gfp.h and slab.h inclusions around .h
       files could easily lead to inclusion dependency hell.  Most gfp.h
       inclusion directives were ignored as stuff from gfp.h was usually
       wildly available and often used in preprocessor macros.  Each
       slab.h inclusion directive was examined and added manually as
    6. percpu.h was updated not to include slab.h.
    7. Build test were done on the following configurations and failures
       were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
       distributed build env didn't work with gcov compiles) and a few
       more options had to be turned off depending on archs to make things
       build (like ipr on powerpc/64 which failed due to missing writeq).
       * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
       * powerpc and powerpc64 SMP allmodconfig
       * sparc and sparc64 SMP allmodconfig
       * ia64 SMP allmodconfig
       * s390 SMP allmodconfig
       * alpha SMP allmodconfig
       * um on x86_64 SMP allmodconfig
    8. percpu.h modifications were reverted so that it could be applied as
       a separate patch and serve as bisection point.
    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.
    Signed-off-by: Tejun Heo <>
    Guess-its-ok-by: Christoph Lameter <>
    Cc: Ingo Molnar <>
    Cc: Lee Schermerhorn <>
Commits on Jul 7, 2009
  1. @herbertx

    crypto: api - Add new template create function

    herbertx committed
    This patch introduces the template->create function intended
    to replace the existing alloc function.  The intention is for
    create to handle the registration directly, whereas currently
    the caller of alloc has to handle the registration.
    This allows type-specific code to be run prior to registration.
    Signed-off-by: Herbert Xu <>
Commits on Jun 2, 2009
  1. @herbertx

    crypto: testmgr - Dynamically allocate xbuf and axbuf

    herbertx committed
    We currently allocate temporary memory that is used for testing
    statically.  This renders the testing engine non-reentrant. As
    algorithms may nest, i.e., one may construct another in order to
    carry out a part of its operation, this is unacceptable.  For
    example, it has been reported that an AEAD implementation allocates
    a cipher in its setkey function, which causes it to fail during
    testing as the temporary memory is overwritten.
    This patch replaces the static memory with dynamically allocated
    buffers.  We need a maximum of 16 pages so this slightly increases
    the chances of an algorithm failing due to memory shortage.
    However, as testing usually occurs at registration, this shouldn't
    be a big problem.
    Reported-by: Shasi Pulijala <>
    Signed-off-by: Herbert Xu <>
Commits on Feb 18, 2009
  1. @herbertx

    crypto: testmgr - Test skciphers with no IVs

    herbertx committed
    As it is an skcipher with no IV escapes testing altogether because
    we only test givcipher objects.  This patch fixes the bypass logic
    to test these algorithms.
    Conversely, we're currently testing nivaead algorithms with IVs,
    which would have deadlocked had it not been for the fact that no
    nivaead algorithms have any test vectors.  This patch also fixes
    that case.
    Both fixes are ugly as hell, but this ugliness should hopefully
    disappear once we move them into the per-type code (i.e., the
    AEAD test would live in aead.c and the skcipher stuff in ablkcipher.c).
    Signed-off-by: Herbert Xu <>
Commits on Aug 29, 2008
  1. @herbertx

    crypto: cryptomgr - Test ciphers using ECB

    herbertx committed
    As it is we only test ciphers when combined with a mode.  That means
    users that do not invoke a mode of operations may get an untested
    This patch tests all ciphers using the ECB mode so that simple cipher
    users such as ansi-cprng are also protected.
    Signed-off-by: Herbert Xu <>
  2. @herbertx

    crypto: api - Use test infrastructure

    herbertx committed
    This patch makes use of the new testing infrastructure by requiring
    algorithms to pass a run-time test before they're made available to
    Signed-off-by: Herbert Xu <>
  3. @herbertx

    crypto: cryptomgr - Add test infrastructure

    herbertx committed
    This patch moves the newly created alg_test infrastructure into
    cryptomgr.  This shall allow us to use it for testing at algorithm
    Signed-off-by: Herbert Xu <>
Something went wrong with that request. Please try again.