Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Oct 6, 2008
  1. Linux 2.6.27-rc9

    authored
  2. Marker depmod fix core kernel list

    Mathieu Desnoyers authored committed
    * Theodore Ts'o (tytso@mit.edu) wrote:
    >
    > I've been playing with adding some markers into ext4 to see if they
    > could be useful in solving some problems along with Systemtap.  It
    > appears, though, that as of 2.6.27-rc8, markers defined in code which is
    > compiled directly into the kernel (i.e., not as modules) don't show up
    > in Module.markers:
    >
    > kvm_trace_entryexit arch/x86/kvm/kvm-intel  %u %p %u %u %u %u %u %u
    > kvm_trace_handler arch/x86/kvm/kvm-intel  %u %p %u %u %u %u %u %u
    > kvm_trace_entryexit arch/x86/kvm/kvm-amd  %u %p %u %u %u %u %u %u
    > kvm_trace_handler arch/x86/kvm/kvm-amd  %u %p %u %u %u %u %u %u
    >
    > (Note the lack of any of the kernel_sched_* markers, and the markers I
    > added for ext4_* and jbd2_* are missing as wel.)
    >
    > Systemtap apparently depends on in-kernel trace_mark being recorded in
    > Module.markers, and apparently it's been claimed that it used to be
    > there.  Is this a bug in systemtap, or in how Module.markers is getting
    > built?   And is there a file that contains the equivalent information
    > for markers located in non-modules code?
    
    I think the problem comes from "markers: fix duplicate modpost entry"
    (commit d35cb36)
    
    Especially :
    
      -   add_marker(mod, marker, fmt);
      +   if (!mod->skip)
      +     add_marker(mod, marker, fmt);
        }
        return;
       fail:
    
    Here is a fix that should take care if this problem.
    
    Thanks for the bug report!
    
    Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
    Tested-by: "Theodore Ts'o" <tytso@mit.edu>
    CC: Greg KH <greg@kroah.com>
    CC: David Smith <dsmith@redhat.com>
    CC: Roland McGrath <roland@redhat.com>
    CC: Sam Ravnborg <sam@ravnborg.org>
    CC: Wenji Huang <wenji.huang@oracle.com>
    CC: Takashi Nishiie <t-nishiie@np.css.fujitsu.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  3. Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel…

    authored
    …/git/jwessel/linux-2.6-kgdb
    
    * 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/linux-2.6-kgdb:
      kgdb: call touch_softlockup_watchdog on resume
      kgdb, x86: Avoid invoking kgdb_nmicallback twice per NMI
  4. Merge branch 'x86-fixes-for-linus' of git://git.kernel.org/pub/scm/li…

    authored
    …nux/kernel/git/tip/linux-2.6-tip
    
    * 'x86-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
      x86: gart iommu have direct mapping when agp is present too
  5. Merge git://git.kernel.org/pub/scm/linux/kernel/git/bart/ide-2.6

    authored
    * git://git.kernel.org/pub/scm/linux/kernel/git/bart/ide-2.6:
      ide: workaround for bogus gcc warning in ide_sysfs_register_port()
      ide-cd: Optiarc DVD RW AD-7200A does play audio
      IDE: Fix platform device registration in Swarm IDE driver (v2)
      ide-dma: fix ide_build_dmatable() for TRM290
      ide-cd: temporary tray close fix
  6. Merge branch 'upstream' of git://ftp.linux-mips.org/pub/scm/upstream-…

    authored
    …linus
    
    * 'upstream' of git://ftp.linux-mips.org/pub/scm/upstream-linus:
      [MIPS] IP27: Fix build errors if CONFIG_MAPPED_KERNEL=y
      [MIPS] Fix CMP Kconfig configuration and mark as broken.
  7. Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git…

    authored
    …/mchehab/v4l-dvb
    
    * 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb: (33 commits)
      V4L/DVB (9103): em28xx: HVR-900 B3C0 - fix audio clicking issue
      V4L/DVB (9099): em28xx: Add detection for K-WORLD DVB-T 310U
      V4L/DVB (9092): gspca: Bad init values for sonixj ov7660.
      V4L/DVB (9080): gspca: Add a delay after writing to the sonixj sensors.
      V4L/DVB (9075): gspca: Bad check of returned status in i2c_read() spca561.
      V4L/DVB (9053): fix buffer overflow in uvc-video
      V4L/DVB (9043): S5H1420: Fix size of shadow-array to avoid overflow
      V4L/DVB (9037): Fix support for Hauppauge Nova-S SE
      V4L/DVB (9029): Fix deadlock in demux code
      V4L/DVB (8979): sms1xxx: Add new USB product ID for Hauppauge WinTV MiniStick
      V4L/DVB (8978): sms1xxx: fix product name for Hauppauge WinTV MiniStick
      V4L/DVB (8967): Use correct XC3028L firmware for AMD ATI TV Wonder 600
      V4L/DVB (8963): s2255drv field count fix
      V4L/DVB (8961): zr36067: Fix RGBR pixel format
      V4L/DVB (8960): drivers/media/video/cafe_ccic.c needs mm.h
      V4L/DVB (8958): zr36067: Return proper bytes-per-line value
      V4L/DVB (8957): zr36067: Restore the default pixel format
      V4L/DVB (8955): bttv: Prevent NULL pointer dereference in radio_open
      V4L/DVB (8935): em28xx-cards: Remove duplicate entry (EM2800_BOARD_KWORLD_USB2800)
      V4L/DVB (8933): gspca: Disable light frquency for zc3xx cs2102 Kokom.
      ...
  8. atmel-mci: Initialize BLKR before sending data transfer command

    Haavard Skinnemoen authored committed
    The atmel-mci driver sometimes fails data transfers like this:
    
       mmcblk0: error -5 transferring data
       end_request: I/O error, dev mmcblk0, sector 2749769
       end_request: I/O error, dev mmcblk0, sector 2749777
    
    It turns out that this might be caused by the BLKR register (which
    contains the block size and the number of blocks being transfered) being
    initialized too late. This patch moves the initialization of BLKR so
    that it contains the correct value before the block transfer command is
    sent.
    
    This error is difficult to reproduce, but if you insert a long delay
    (mdelay(10) or thereabouts) between the calls to atmci_start_command()
    and atmci_submit_data(), all transfers seem to fail without this patch,
    while I haven't seen any failures with this patch.
    
    Reported-by: Hein_Tibosch <hein_tibosch@yahoo.es>
    Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
    Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  9. @jwessel

    kgdb: call touch_softlockup_watchdog on resume

    jwessel authored
    The softlockup watchdog needs to be touched when resuming the from the
    kgdb stopped state to avoid the printk that a CPU is stuck if the
    debugger was active for longer than the softlockup threshold.
    
    Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
  10. @jan-kiszka @jwessel

    kgdb, x86: Avoid invoking kgdb_nmicallback twice per NMI

    jan-kiszka authored jwessel committed
    Stress-testing KVM's latest NMI support with kgdbts inside an SMP guest,
    I came across spurious unhandled NMIs while running the singlestep test.
    Looking closer at the code path each NMI takes when KGDB is enabled, I
    noticed that kgdb_nmicallback is called twice per event: One time via
    DIE_NMI_IPI notification, the second time on DIE_NMI. Removing the first
    invocation cures the unhandled NMIs here.
    
    Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
    Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
  11. @rjwysocki

    x86 ACPI: Blacklist two HP machines with buggy BIOSes

    rjwysocki authored committed
    There is a bug in the BIOSes of some HP boxes with AMD Turions which
    connects IO-APIC pins with ACPI thermal trip points in such a way that
    if the state of the IO-APIC is not as expected by the (buggy) BIOS, the
    thermal trip points are set to insanely low values (usually all of them
    become 16 degrees Celsius).  As a result, thermal throttling kicks in
    and knock the system down to its shoes.
    
    Unfortunately some of the recent IO-APIC changes made the bug show up.
    To prevent this from happening, blacklist machines that are known to be
    affected (nx6115 and 6715b in this particular case).
    
    This fixes http://bugzilla.kernel.org/show_bug.cgi?id=11516 listed as
    a regression from 2.6.26.
    
    On my box it was caused by:
    
    commit 691874f
    Author: Maciej W. Rozycki <macro@linux-mips.org>
    Date:   Tue May 27 21:19:51 2008 +0100
    
        x86: I/O APIC: timer through 8259A second-chance
    
        Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
        Signed-off-by: Ingo Molnar <mingo@elte.hu>
    
    and the whole story is described in this (huge) thread:
    
        http://marc.info/?l=linux-kernel&m=121358440508410&w=4
    
    Matthew Garrett told us about that happening on the nx6125:
    
        http://marc.info/?l=linux-kernel&m=121396307411930&w=4
    
    and then Maciej analysed the breakage on the basis of a DSDT from the
    nx6325:
    
        http://marc.info/?l=linux-kernel&m=121401068718826&w=4
    
    As far as the Dmitry's and Jason's boxes are concerned, I recognized the
    symptoms and asked them to verify that the blacklisting helped.
    
    It appears that the buggy BIOS code has been copy-pasted to the entire
    range of machines, for no good reason.
    
    Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    Tested-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Tested-by: Jason Vas Dias <jason.vas.dias@gmail.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  12. @ralfbaechle

    [MIPS] IP27: Fix build errors if CONFIG_MAPPED_KERNEL=y

    ralfbaechle authored
    Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  13. @ralfbaechle

    [MIPS] Fix CMP Kconfig configuration and mark as broken.

    ralfbaechle authored
    Because sync-r4k.c doesn't build.
    
    Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Commits on Oct 5, 2008
  1. @bzolnier

    ide: workaround for bogus gcc warning in ide_sysfs_register_port()

    bzolnier authored
    Reported-by: "Steven Noonan" <steven@uplinklabs.net>
    Suggested-by: "Elias Oltmanns" <eo@nebensachen.de>
    Cc: mingo@elte.hu
    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  2. @7eggert @bzolnier

    ide-cd: Optiarc DVD RW AD-7200A does play audio

    7eggert authored bzolnier committed
    The Optiarc DVD RW AD-7200A can play audio, but tells it could not.
    
    Signed-off-by: Bodo Eggert <7eggert@gmx.de>
    Tested-by: Nick Warne <nick@ukfsn.org>
    Received-from: Borislav Petkov <petkovbb@googlemail.com>
    [bart: keep "audio" quirks together]
    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  3. @ralfbaechle @bzolnier

    IDE: Fix platform device registration in Swarm IDE driver (v2)

    ralfbaechle authored bzolnier committed
    The Swarm IDE driver uses a release method which is defined in the driver
    itself thus potentially oopsable.  The simple fix would be to just leak
    the device but this patch goes the full length and moves the entire
    handling of the platform device in the platform code and retains only
    the platform driver code in drivers/ide/mips/swarm.c.
    
    Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
    Cc: "Maciej W. Rozycki" <macro@linux-mips.org>
    Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
    [bart: remove no longer needed BLK_DEV_IDE_SWARM from ide/Kconfig]
    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  4. @bzolnier

    ide-dma: fix ide_build_dmatable() for TRM290

    Sergei Shtylylov authored bzolnier committed
    Apparently, 'xcount' being 0 does not mean 0 bytes for TRM290; it means 4 bytes,
    judging from the code immediately preceding this check.  So, we must never try
    to "split" the PRD for TRM290.
    
    This is probably never hit anyway -- with the DMA buffers aligned to at least
    512 bytes and ATAPI DMA not being used for non block I/O commands...
    
    Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  5. @bzolnier

    ide-cd: temporary tray close fix

    Borislav Petkov authored bzolnier committed
    This one fixes http://bugzilla.kernel.org/show_bug.cgi?id=11602.
    
    A more generic fix for drives which cannot autoclose tray will follow.
    
    Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
    Cc: Jens Axboe <jens.axboe@oracle.com>
    [bart: add an extra parentheses for consistency with the rest of kernel code]
    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  6. @yhlu

    x86: gart iommu have direct mapping when agp is present too

    yhlu authored Ingo Molnar committed
    move init_memory_mapping() out of init_k8_gatt.
    
    for: http://bugzilla.kernel.org/show_bug.cgi?id=11676
        2.6.27-rc2 to rc8, apgart fails, iommu=soft works, regression
    
    This is needed because we need to map the GART aperture even
    if the GATT is not initialized.
    
    Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
  7. V4L/DVB (9103): em28xx: HVR-900 B3C0 - fix audio clicking issue

    Wiktor Grebla authored Mauro Carvalho Chehab committed
    Fixed audio clicking problem which could be heard when using analog tv or composite input
    
    Signed-off-by: Wiktor Grebla <greblus@gmail.com>
    Signed-off-by: Douglas Schilling Landgraf <dougsland@linuxtv.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  8. @nroff-man

    V4L/DVB (9099): em28xx: Add detection for K-WORLD DVB-T 310U

    nroff-man authored Mauro Carvalho Chehab committed
    Correct firmware type to MTS
    Correct audio routing for composite/s-video
    Add DVB-T detection.
    
    This patch uses the eeprom hash method for detection as the vendor/product
    ids are also used for the DIGIVOX_AD. This may be a clone of the same
    product. Explanatory text has been added prior to the hask look-up in
    anticipation that it may help others.
    
    The following has been tested to work:
    Analogue TV (PAL-I)
    Composite In
    DVB-T (UK Crystal Palace)
    USB AUDIO
    
    The following has not been tested but probably works:
    S-Video In
    
    Signed-off-by: Darron Broad <darron@kewl.org>
    Signed-off-by: Douglas Schilling Landgraf <dougsland@linuxtv.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  9. V4L/DVB (9092): gspca: Bad init values for sonixj ov7660.

    Jean-Francois Moine authored Mauro Carvalho Chehab committed
    Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  10. V4L/DVB (9080): gspca: Add a delay after writing to the sonixj sensors.

    Jean-Francois Moine authored Mauro Carvalho Chehab committed
    Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  11. V4L/DVB (9075): gspca: Bad check of returned status in i2c_read() spc…

    Shane authored Mauro Carvalho Chehab committed
    …a561.
    
    This makes auto gain functional on 04fc:0561.
    
    Signed-off-by: Shane <gnome42@gmail.com>
    Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  12. @rcls

    V4L/DVB (9053): fix buffer overflow in uvc-video

    rcls authored Mauro Carvalho Chehab committed
    There is a buffer overflow in drivers/media/video/uvc/uvc_ctrl.c:
    
    INFO: 0xf2c5ce08-0xf2c5ce0b. First byte 0xa1 instead of 0xcc
    INFO: Allocated in uvc_query_v4l2_ctrl+0x3c/0x239 [uvcvideo] age=13 cpu=1 pid=4975
    ...
    
    A fixed size 8-byte buffer is allocated, and a variable size field is read
    into it; there is no particular bound on the size of the field (it is
    dependent on hardware and configuration) and it can overflow [also
    verified by inserting printk's.]
    
    The patch attempts to size the buffer to the correctly.
    
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Acked-by: Laurent Pinchart <laurent.pinchart@skynet.be>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  13. V4L/DVB (9043): S5H1420: Fix size of shadow-array to avoid overflow

    Patrick Boettcher authored Mauro Carvalho Chehab committed
    The array size of 'shadow' still needs to be fixed in order to not overflow when reading register 0x00.
    
    Thanks to Oliver Endriss for pointing that out.
    
    Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  14. V4L/DVB (9037): Fix support for Hauppauge Nova-S SE

    Patrick Boettcher authored Mauro Carvalho Chehab committed
    Different backends have different input busses (saa7146, flexcop).
    To reflect that a config-option to the s5h1420-driver was added which makes
    the output mode selectable.
    
    Furthermore the s5h1420-driver is now doing the same i2c-method as it was done
    before adding support for other i2c-users.
    
    This patch needs to go into the current release of the kernel, as this driver
    is currently broken.
    
    (Thanks to Eberhard Kaltenhaeuser for helping out to debug this issue.)
    
    Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  15. V4L/DVB (9029): Fix deadlock in demux code

    Andreas Oberritter authored Mauro Carvalho Chehab committed
    The functions dvb_dmxdev_section_callback, dvb_dmxdev_ts_callback,
    dvb_dmx_swfilter_packet, dvb_dmx_swfilter_packets, dvb_dmx_swfilter and
    dvb_dmx_swfilter_204 may be called from both interrupt and process
    context. Therefore they need to be protected by spin_lock_irqsave()
    instead of spin_lock().
    
    This fixes a deadlock discovered by lockdep.
    
    Signed-off-by: Andreas Oberritter <obi@linuxtv.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  16. @mkrufky

    V4L/DVB (8979): sms1xxx: Add new USB product ID for Hauppauge WinTV M…

    mkrufky authored Mauro Carvalho Chehab committed
    …iniStick
    
    2040:5510 is the same hardware as 2040:5500
    
    Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  17. @mkrufky

    V4L/DVB (8978): sms1xxx: fix product name for Hauppauge WinTV MiniStick

    mkrufky authored Mauro Carvalho Chehab committed
    Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  18. V4L/DVB (8967): Use correct XC3028L firmware for AMD ATI TV Wonder 600

    Devin Heitmueller authored Mauro Carvalho Chehab committed
    The AMD ATI TV Wonder 600 has an XC3028L and *not* an XC3028, so we need to
    load the proper firmware to prevent the device from overheating.
    
    Signed-off-by: Devin Heitmueller <devin.heitmueller@gmail.com>
    Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  19. @deansensoray

    V4L/DVB (8963): s2255drv field count fix

    deansensoray authored Mauro Carvalho Chehab committed
    Fixes videobuf field_count
    
    Signed-off-by: Dean Anderson <dean@sensoray.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  20. V4L/DVB (8961): zr36067: Fix RGBR pixel format

    Jean Delvare authored Mauro Carvalho Chehab committed
    The zr36067 driver is improperly declaring pixel format RGBP twice,
    once as "16-bit RGB LE" and once as "16-bit RGB BE". The latter is
    actually RGBR. Fix the code to properly map both pixel formats.
    
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Acked-by: Trent Piepho <xyzzy@speakeasy.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  21. V4L/DVB (8960): drivers/media/video/cafe_ccic.c needs mm.h

    Andrew Morton authored Mauro Carvalho Chehab committed
    sparc32 allmodconfig:
    
    drivers/media/video/cafe_ccic.c: In function 'cafe_setup_siobuf':
    drivers/media/video/cafe_ccic.c:1192: error: implicit declaration of function 'PAGE_ALIGN'
    drivers/media/video/cafe_ccic.c: At top level:
    drivers/media/video/cafe_ccic.c:1430: error: variable 'cafe_v4l_vm_ops' has initializer but incomplete type
    drivers/media/video/cafe_ccic.c:1431: error: unknown field 'open' specified in initializer
    drivers/media/video/cafe_ccic.c:1431: warning: excess elements in struct initializer
    drivers/media/video/cafe_ccic.c:1431: warning: (near initialization for 'cafe_v4l_vm_ops')
    drivers/media/video/cafe_ccic.c:1432: error: unknown field 'close' specified in initializer
    drivers/media/video/cafe_ccic.c:1433: warning: excess elements in struct initializer
    drivers/media/video/cafe_ccic.c:1433: warning: (near initialization for 'cafe_v4l_vm_ops')
    drivers/media/video/cafe_ccic.c: In function 'cafe_v4l_mmap':
    drivers/media/video/cafe_ccic.c:1444: error: 'VM_WRITE' undeclared (first use in this function)
    drivers/media/video/cafe_ccic.c:1444: error: (Each undeclared identifier is reported only once
    drivers/media/video/cafe_ccic.c:1444: error: for each function it appears in.)
    drivers/media/video/cafe_ccic.c:1444: error: 'VM_SHARED' undeclared (first use in this function)
    drivers/media/video/cafe_ccic.c:1461: error: 'VM_DONTEXPAND' undeclared (first use in this function)
    
    This build breakage is caused by some header file shuffle in linux-next.  But
    I suggest that this patch be merged ahead of linux-next to avoid bisection
    breakage.
    
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  22. V4L/DVB (8958): zr36067: Return proper bytes-per-line value

    Jean Delvare authored Mauro Carvalho Chehab committed
    The zr36067 driver should return the actual bytes-per-line value when
    queried with ioctl VIDIOC_G_FMT, instead of 0. Otherwise user-space
    applications can get confused.
    
    Likewise, with ioctl VIDIOC_S_FMT, we are supposed to fill the
    bytes-per-line value. And we shouldn't fail if the caller sets the
    initial value to something different from 0. This is perfectly valid
    for applications to pre-fill this field with the value they expect.
    
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Something went wrong with that request. Please try again.