Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for AR5BBU22 [0489:e03c] #17
I don't do github pull requests.
github throws away all the relevant information, like having even a
Git comes with a nice pull-request generation module, but github
I've told github people about my concerns, they didn't think they
On Fri, May 11, 2012 at 4:27 AM, Roman
On Fri, May 11, 2012 at 1:03 PM, orblivion
Read my email.
I have no problem with people using github as a hosting site.
But in order for me to pull from github, you need to
(a) make a real pull request, not the braindamaged crap that github
(b) since github identities are random, I expect the pull request to
I also refuse to pull commits that have been made with the github web
github could make it easy to write good commit messages and enforce
Maybe some of this has changed, I haven't checked lately. But in
I'm writing these explanations in the (probably vain) hope that people
And the fact that other projects apparently have so low expectations
Btw, Joseph, you're a quality example of why I detest the github
The fact that I have higher standards then makes people like you make
You're a moron.
Every time another Pull Request fiasco happens on one of Linus's repos it makes me sad, especially because I want someone whose work I greatly respect, to have a good experience on GitHub - instead he gets dozens of troll comments.
An OS kernel very rightfully demands a very disciplined approach to development that is in many ways not compatible with the goals of GitHub, which is to get as many people of all skill levels involved in Free / Open Source Software. We can certainly make improvements though, and I appreciate that Linus has taken some time to detail exactly why he doesn't use PRs, even if it's a bit harsh.
I think this is only because people who are new to Git are using GitHub and not understanding about Git-style committing. Remember, a lot of these newbies are just out of the gate from using SVN for years. I bet a lot of them don't even realize that
I have to agree with you there. Commit message viewing on Github sucks and I hope they change it soon.
On Fri, May 11, 2012 at 1:29 PM, Mike Skalnik
No it doesn't.
What it supports is writing long lines that you have not a f*cking
In other words, it makes it very hard indeed to do "nicely formatted
So the github commit UI should have
It didn't do any of those last time I checked.
On Fri, May 11, 2012 at 1:40 PM, Tom Scott
The thing is, even if you do understand about git-style committing,
The best way to do it is literally to open up another text editor
Yes, commit messages should have proper word-wrap, with empty lines in
And yes, that would almost require some kind of "markup" format with
Right now, github simply seems to default to "broken horrible
And I think it should default to "nice readable messages" with some
On Fri, May 11, 2012 at 1:48 PM, Dominik Dabrowski
Umm. I think I've been able to reach my goals on the internet better
The fact that I'm very clear about my opinions is probably part of it.
If people get offended by accurate portrayals of the current state of
I hate that whole "victim philosophy". The truth shouldn't be sugarcoated.
While I do have great respect for you @torvalds and your work, and it's totally valid for the repository of Linux to have rather rigorous standards, have you considered the possibility there could be a lot of GitHub users who don't really need nor care about any of those "features" you try to portray as objectively superior?
On Fri, May 11, 2012 at 1:49 PM, Daniel Nugent
No it shouldn't.
Word-wrapping is a property of the text. And the tool you use to
Some things should not be word-wrapped. They may be some kind of
The tool displaying the thing can't know. The person writing the
Sure, the alternative would be to have commit messages be some
(And the rule is not 80 characters, because you do want to allow the
Anyway, you are obviously free to do your commit messages any way you
And quite frankly, anybody who thinks they have better rules had
So I would suggest taking the cue for good log messages from projects
On Fri, May 11, 2012 at 2:01 PM, Prathan Thananart
And when those people with lower standards try to get their commits
Btw, the commit message rules we use in the kernel really are
On Fri, May 11, 2012 at 2:03 PM, Mahmut Bulut
.. because I think github does some things very well.
So sure, you may think I hate github. I don't. I hate very specific
But other parts are done really really well.
I think github does a stellar job at the actual hosting part. I
That's wonderful. I think github is absolutely lovely in many respects.
And that then makes me really annoyed at the places where I think
Just curious - why is it that the tool used to visualize things cannot know how to wrap text it displays? And if it is the case, isn't that a problem with the viewer itself, rather than a reason to hard wrap?
Do you guys not understand that this is Linus' blessed repository and he can accept and reject whomever and whichever request he likes? He has specific and pertinent rules when it comes to merging that he's learned over 20 years of maintaining the Linux kernel. He developed git - in case you forgot, he was the initial developer - with features specifically for gpg signoffs, shortlogs, etc. - things he and other intelligent computer scientists find useful for maintaining repositories.
I've maintained small projects with three developers plus myself and as soon as you become loose with your merging criteria, the entire repository goes to hell. If he wants gpg signoffs, then he'll get gpg signoffs. Try maintaining 20 millions lines of code and merges requests from 2,000 developers, and then you can give Linus advise.
"GitHub is the best place to share code with friends, co-workers,
Roman, in the future, you should follow the kernel's guide for
FWIW, Reviewed-by: Corbin Simpson MostAwesomeDude@gmail.com, but
(As an example of broken UI, while writing this message, I split my