Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this code very fast #437

Open
wants to merge 2 commits into
base: master
from

Conversation

@ahmetilgin
Copy link

commented Jul 17, 2017

remove empty characters

this code very fast
remove empty characters
@KernelPRBot

This comment has been minimized.

Copy link

commented Jul 17, 2017

Hi @ahmetilgin!

Thanks for your contribution to the Linux kernel!

Linux kernel development happens on mailing lists, rather than on GitHub - this GitHub repository is a read-only mirror that isn't used for accepting contributions. So that your change can become part of Linux, please email it to us as a patch.

Sending patches isn't quite as simple as sending a pull request, but fortunately it is a well documented process.

Here's what to do:

  • Format your contribution according to kernel requirements
  • Decide who to send your contribution to
  • Set up your system to send your contribution as an email
  • Send your contribution and wait for feedback

How do I format my contribution?

The Linux kernel community is notoriously picky about how contributions are formatted and sent. Fortunately, they have documented their expectations.

Firstly, all contributions need to be formatted as patches. A patch is a plain text document showing the change you want to make to the code, and documenting why it is a good idea.

You can create patches with git format-patch.

Secondly, patches need 'commit messages', which is the human-friendly documentation explaining what the change is and why it's necessary.

Thirdly, changes have some technical requirements. There is a Linux kernel coding style, and there are licensing requirements you need to comply with.

Both of these are documented in the Submitting Patches documentation that is part of the kernel.

Note that you will almost certainly have to modify your existing git commits to satisfy these requirements. Don't worry: there are many guides on the internet for doing this.

Who do I send my contribution to?

The Linux kernel is composed of a number of subsystems. These subsystems are maintained by different people, and have different mailing lists where they discuss proposed changes.

If you don't already know what subsystem your change belongs to, the get_maintainer.pl script in the kernel source can help you.

get_maintainer.pl will take the patch or patches you created in the previous step, and tell you who is responsible for them, and what mailing lists are used. You can also take a look at the MAINTAINERS file by hand.

Make sure that your list of recipients includes a mailing list. If you can't find a more specific mailing list, then LKML - the Linux Kernel Mailing List - is the place to send your patches.

It's not usually necessary to subscribe to the mailing list before you send the patches, but if you're interested in kernel development, subscribing to a subsystem mailing list is a good idea. (At this point, you probably don't need to subscribe to LKML - it is a very high traffic list with about a thousand messages per day, which is often not useful for beginners.)

How do I send my contribution?

Use git send-email, which will ensure that your patches are formatted in the standard manner. In order to use git send-email, you'll need to configure git to use your SMTP email server.

For more information about using git send-email, look at the Git documentation or type git help send-email. There are a number of useful guides and tutorials about git send-email that can be found on the internet.

How do I get help if I'm stuck?

Firstly, don't get discouraged! There are an enormous number of resources on the internet, and many kernel developers who would like to see you succeed.

Many issues - especially about how to use certain tools - can be resolved by using your favourite internet search engine.

If you can't find an answer, there are a few places you can turn:

  • Kernel Newbies - this website contains a lot of useful resources for new kernel developers.
  • If you'd like a step-by-step, challenge-based introduction to kernel development, the Eudyptula Challenge would be an excellent start.
  • The kernel documentation - see also the Documentation directory in the kernel tree.

If you get really, really stuck, you could try the owners of this bot, @daxtens and @ajdlinux. Please be aware that we do have full-time jobs, so we are almost certainly the slowest way to get answers!

I sent my patch - now what?

You wait.

You can check that your email has been received by checking the mailing list archives for the mailing list you sent your patch to. Messages may not be received instantly, so be patient. Kernel developers are generally very busy people, so it may take a few weeks before your patch is looked at.

Then, you keep waiting. Three things may happen:

  • You might get a response to your email. Often these will be comments, which may require you to make changes to your patch, or explain why your way is the best way. You should respond to these comments, and you may need to submit another revision of your patch to address the issues raised.
  • Your patch might be merged into the subsystem tree. Code that becomes part of Linux isn't merged into the main repository straight away - it first goes into the subsystem tree, which is managed by the subsystem maintainer. It is then batched up with a number of other changes sent to Linus for inclusion. (This process is described in some detail in the kernel development process guide).
  • Your patch might be ignored completely. This happens sometimes - don't take it personally. Here's what to do:
    • Wait a bit more - patches often take several weeks to get a response; more if they were sent at a busy time.
    • Kernel developers often silently ignore patches that break the rules. Check for obvious violations of the the Submitting Patches guidelines, the style guidelines, and any other documentation you can find about your subsystem. Check that you're sending your patch to the right place.
    • Try again later. When you resend it, don't add angry commentary, as that will get your patch ignored. It might also get you silently blacklisted.

Further information

Happy hacking!

This message was posted by a bot - if you have any questions or suggestions, please talk to my owners, @ajdlinux and @daxtens, or raise an issue at https://github.com/ajdlinux/KernelPRBot.

@thibmo

This comment has been minimized.

Copy link

commented Jul 18, 2017

Also, hope you are kidding with this one.. 😅

@kylelamse

This comment has been minimized.

Copy link

commented Jul 19, 2017

i think this should get merged in

@kylelamse

This comment has been minimized.

Copy link

commented Jul 19, 2017

@ItzLevvie Don't you think it's easier to read? It's now only one line of code!

@Blaze349

This comment has been minimized.

Copy link

commented Jul 22, 2017

@ahmetilgin The kernel is written in C. C isn't an interpreted language like JS. Instead, it is compiled. Empty characters and spaces don't affect execution speed.

That being said: It looks much more readable than the current code.

@dadur604
Copy link

left a comment

Do you need help?

@Dot-Rar

This comment has been minimized.

Copy link

commented Jul 22, 2017

Yes is dank agree

@Jonathan50

This comment has been minimized.

Copy link

commented Jul 23, 2017

@Blaze349 The Linux kernel takes soooooo long to compile. This will increase compilation speed by removing all the unnecessary whitespace the compiler has to skip over.

@Jonathan50
Copy link

left a comment

Everybody loves it 100% (Ok I'm sorry for saying that)

@Blaze349
Copy link

left a comment

@Jonathan50 is right. This code definitely very fast. But it can be improved. There is an empty line between the includes and code. Please fix

@Blaze349
Copy link

left a comment

Perfect. Almost. All the comments should be on one line to increase speed.

@7bf70ec5

This comment has been minimized.

Copy link

commented Jul 23, 2017

@kylelamse Are you joking? Minifying a code doesn't make it 'readable'... In Javascript it's used to reduce bandwidth between server & the user, reduce page execution time & reduce file size

@ahmetilgin don't bother wasting your time on the PR. This won't improve anything except for decreasing file size. Also, there are a lot of comments in the 'minified code' that you've not bothered to remove. But again don't bother about it.

@Jonathan50 If a Linux kernel takes 'soo long to compile' then you need to invest in a better CPU like Xeon. Compiling Android or a kernel requires you to have more cores to speed up the compiling process. If you have less cores then it will take more time to compile.

No one loves the code unless it's a sarcasm

@ItzLevvie I do have to agree, this won't get accepted anyways because of contributing guidelines. So you don't have to worry about it.

@dadur604 no he doesn't need any help.. he's just trying to make the community laugh by committing garbage code.

@Blaze349 C is already fast enough... there's no need to do all the stuff the compiler will do it for you automatically or you can add some flags to optimise it.

@thibmo I believe he's trying to make the community laugh. If it's serious then I would obliviously laugh even more.

@Blaze349

This comment has been minimized.

Copy link

commented Jul 23, 2017

@7bf70ec5 Linus Torvalds uses a Macbook Air so...yeah. Also, the kernel isn't written in C# 🤣 . It's written in C and a little Assembly.

@kylelamse

This comment has been minimized.

Copy link

commented Jul 24, 2017

@dizaztor Should be easier. You no longer have to scroll through thousands of lines of code. Having it on one line just makes sense.

@pichardoJ

This comment has been minimized.

Copy link

commented Jul 24, 2017

Wow, now that's some beautiful code aesthetics. Congrats

@Dot-Rar

This comment has been minimized.

Copy link

commented Jul 24, 2017

@dizaztor why maintain when you can not maintain

@iamsubhranil

This comment has been minimized.

Copy link

commented Jul 25, 2017

Are you seriously kidding me?😂

@ghost

This comment has been minimized.

Copy link

commented Jul 25, 2017

yes this is beautiful 10/10

@kylelamse

This comment has been minimized.

Copy link

commented Jul 25, 2017

No one loves the code unless it's a sarcasm

@7bf70ec5

@dschwartz783

This comment has been minimized.

Copy link

commented Jul 26, 2017

I've never laughed at code so hard in my life. Thanks for that! Definitely a much needed contribution. Linus has nothing on this guy.

Perhaps this should go into a new Linux for Comedy branch.

@PeterAlfonsLoch

This comment has been minimized.

Copy link

commented Jul 26, 2017

Thats just, thats's hmm what is it?..... It's ART :D Put it in a Museum.

@iamunknown2

This comment has been minimized.

Copy link

commented Jul 26, 2017

10/10 best commit ever made (other than adding rm -rf / to ~/.bashrc)

@hanss314

This comment has been minimized.

Copy link

commented Jul 27, 2017

This made me laugh so hard. I want Linus's reaction on this now.

@vusonhust

This comment has been minimized.

Copy link

commented Jul 27, 2017

Linus will say "f**k you" like when he told Nvidia ✌️

@numbqq

This comment has been minimized.

Copy link

commented Jul 28, 2017

Good job!

@ryoung9550
Copy link

left a comment

Needs to be structured a bit better.

@m0x23

This comment has been minimized.

Copy link

commented Jul 30, 2017

🍌

@tilda

tilda approved these changes Aug 2, 2017

Copy link

left a comment

+1 Good commit

I'd really like to see @torvalds reacting to this 🤣

@Serkan-devel

This comment has been minimized.

Copy link

commented Aug 9, 2018

@knstn-project scroll at the right panel until you see an "unsubscribe" button

@revmischa

This comment has been minimized.

Copy link

commented Aug 9, 2018

@knstn-project click "mute this thread"

@est

This comment has been minimized.

Copy link

commented Oct 9, 2018

How newlines affect Linux kernel performance

https://nadav.amit.zone/blog/linux-inline

lolwhat

@agungyuliaji

This comment has been minimized.

Copy link

commented Apr 26, 2019

@codenoid please don't mention me, you don't know me, i don't know you 🐒

lopsided98 pushed a commit to lopsided98/linux that referenced this pull request Apr 27, 2019

Merge pull request torvalds#437 from libos-nuse/fix-osname-uname
lkl-upstream: use uname to detect host OS
@Kefta

This comment has been minimized.

Copy link

commented Apr 29, 2019

@agungyuliaji

@ItzLevvie
Copy link

left a comment

­

@revmischa

This comment has been minimized.

Copy link

commented Apr 29, 2019

@agungyuliaji sorry why should people not mention you if they don't know you?

@arnavb

This comment has been minimized.

Copy link

commented Apr 29, 2019

Well it's rude for one thing. People don't want random notifications from unknown people, especially those that might waste their time.

@chessai

This comment has been minimized.

Copy link

commented Apr 30, 2019

In time, the bravest of the children of Ecma will find their way into the fiercest bastions of paganism of old. With their chin up, and their sword held firmly, they know that the battle will not be won by a single blow but by a thousand cuts.

@dschwartz783

This comment has been minimized.

Copy link

commented May 3, 2019

@codenoid You are now blocked.

@Raymonf

This comment has been minimized.

Copy link

commented May 3, 2019

@codenoid If you keep mentioning me then I'll do the same to you out of spite. Stop.

@codenoid

This comment has been minimized.

Copy link

commented May 3, 2019

@codenoid You are now blocked.

NOOOOOOOOOOOOOOOOOOOOOOOOOOO

@codenoid

This comment has been minimized.

Copy link

commented May 3, 2019

Come join my friend, infinity discussion about captain marvel !
erere

@tilda

This comment has been minimized.

Copy link

commented May 3, 2019

thanks for the spam, appreciated by no one

@dschwartz783

This comment has been minimized.

Copy link

commented May 3, 2019

@davr Blocked you too. I'm sure you guys don't care, but I don't care either. I can block you children all day, so keep it coming.

@fqlx

This comment has been minimized.

Copy link

commented May 3, 2019

Anyone else unsub'd from this thread and keep getting resubscribed? 👎👎👎

@toloveru

This comment has been minimized.

Copy link

commented May 5, 2019

Anyone else unsub'd from this thread and keep getting resubscribed? 👎👎👎

Yep, getting that here as well. It clutters my mailbox despite me having turned off notifications for this issue several times now, really annoying.

@codenoid

This comment has been minimized.

Copy link

commented May 5, 2019

delete your github account

@tilda

This comment has been minimized.

Copy link

commented May 6, 2019

@codenoid Maybe you should do that yourself?

@oguzalb

This comment has been minimized.

Copy link

commented Jun 4, 2019

@tilda he can't delete your github account

@SirYummy

This comment has been minimized.

Copy link

commented Jun 4, 2019

@tilda

This comment has been minimized.

Copy link

commented Jun 4, 2019

@oguzalb are you mentally challenged

@domrachev-insegment
Copy link

left a comment

Good!

@oguzalb

This comment has been minimized.

Copy link

commented Jun 5, 2019

@tilda thanks most appreciated, pls mark as resolved

@larshb
Copy link

left a comment

no

@codenoid

This comment has been minimized.

Copy link

commented Jun 10, 2019

@larshb are you pewdiepie ?

@Xaleth

This comment has been minimized.

Copy link

commented Jun 13, 2019

Hmm, what is this heresy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.