Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
this code very fast #437
Thanks for your contribution to the Linux kernel!
Linux kernel development happens on mailing lists, rather than on GitHub - this GitHub repository is a read-only mirror that isn't used for accepting contributions. So that your change can become part of Linux, please email it to us as a patch.
Sending patches isn't quite as simple as sending a pull request, but fortunately it is a well documented process.
Here's what to do:
How do I format my contribution?
The Linux kernel community is notoriously picky about how contributions are formatted and sent. Fortunately, they have documented their expectations.
Firstly, all contributions need to be formatted as patches. A patch is a plain text document showing the change you want to make to the code, and documenting why it is a good idea.
You can create patches with
Secondly, patches need 'commit messages', which is the human-friendly documentation explaining what the change is and why it's necessary.
Thirdly, changes have some technical requirements. There is a Linux kernel coding style, and there are licensing requirements you need to comply with.
Both of these are documented in the Submitting Patches documentation that is part of the kernel.
Note that you will almost certainly have to modify your existing git commits to satisfy these requirements. Don't worry: there are many guides on the internet for doing this.
Who do I send my contribution to?
The Linux kernel is composed of a number of subsystems. These subsystems are maintained by different people, and have different mailing lists where they discuss proposed changes.
If you don't already know what subsystem your change belongs to, the
Make sure that your list of recipients includes a mailing list. If you can't find a more specific mailing list, then LKML - the Linux Kernel Mailing List - is the place to send your patches.
It's not usually necessary to subscribe to the mailing list before you send the patches, but if you're interested in kernel development, subscribing to a subsystem mailing list is a good idea. (At this point, you probably don't need to subscribe to LKML - it is a very high traffic list with about a thousand messages per day, which is often not useful for beginners.)
How do I send my contribution?
For more information about using
How do I get help if I'm stuck?
Firstly, don't get discouraged! There are an enormous number of resources on the internet, and many kernel developers who would like to see you succeed.
Many issues - especially about how to use certain tools - can be resolved by using your favourite internet search engine.
If you can't find an answer, there are a few places you can turn:
If you get really, really stuck, you could try the owners of this bot, @daxtens and @ajdlinux. Please be aware that we do have full-time jobs, so we are almost certainly the slowest way to get answers!
I sent my patch - now what?
You can check that your email has been received by checking the mailing list archives for the mailing list you sent your patch to. Messages may not be received instantly, so be patient. Kernel developers are generally very busy people, so it may take a few weeks before your patch is looked at.
Then, you keep waiting. Three things may happen:
@ahmetilgin don't bother wasting your time on the PR. This won't improve anything except for decreasing file size. Also, there are a lot of comments in the 'minified code' that you've not bothered to remove. But again don't bother about it.
@Jonathan50 If a Linux kernel takes 'soo long to compile' then you need to invest in a better CPU like Xeon. Compiling Android or a kernel requires you to have more cores to speed up the compiling process. If you have less cores then it will take more time to compile.
No one loves the code unless it's a sarcasm
@ItzLevvie I do have to agree, this won't get accepted anyways because of contributing guidelines. So you don't have to worry about it.
@dadur604 no he doesn't need any help.. he's just trying to make the community laugh by committing garbage code.
@Blaze349 C is already fast enough... there's no need to do all the stuff the compiler will do it for you automatically or you can add some flags to optimise it.
@thibmo I believe he's trying to make the community laugh. If it's serious then I would obliviously laugh even more.
On Tue, Jun 4, 2019, 11:29 AM oguzalb ***@***.***> wrote: @tilda <https://github.com/tilda> he can't delete your github account — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#437?email_source=notifications&email_token=AHXIVKWKQTRN52LMFBIKC4DPY2X6XA5CNFSM4DTIX76KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW5OAJI#issuecomment-498786341>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHXIVKRETYBKZPJF7DHNCPTPY2X6XANCNFSM4DTIX76A> .