Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixed typo in comment #77

Open
wants to merge 1 commit into from

1 participant

Colin
Colin

Changed "then" to "than"
No functional change

Colin kiteflyingmonkey Fixed typo in comment
Changed "then" to "than"
No functional change
b35078a
Colin

Ok, after submitting this and reading the comments on some of the other pull requests I see that this isn't going to get accepted. I'll try and do it the way suggested here: https://github.com/torvalds/linux/blob/master/Documentation/SubmittingPatches

Do comment typo style fixes get accepted, or do they need to be bundled with something actually useful?

Nick Dyer ndyer referenced this pull request from a commit in ndyer/linux
Borislav Petkov x86/boot: Further compress CPUs bootup message
Turn it into (for example):

[    0.073380] x86: Booting SMP configuration:
[    0.074005] .... node   #0, CPUs:          #1   #2   #3   #4   #5   #6   #7
[    0.603005] .... node   #1, CPUs:     #8   #9  #10  #11  #12  #13  #14  #15
[    1.200005] .... node   #2, CPUs:    #16  #17  #18  #19  #20  #21  #22  #23
[    1.796005] .... node   #3, CPUs:    #24  #25  #26  #27  #28  #29  #30  #31
[    2.393005] .... node   #4, CPUs:    #32  #33  #34  #35  #36  #37  #38  #39
[    2.996005] .... node   #5, CPUs:    #40  #41  #42  #43  #44  #45  #46  #47
[    3.600005] .... node   #6, CPUs:    #48  #49  #50  #51  #52  #53  #54  #55
[    4.202005] .... node   #7, CPUs:    #56  #57  #58  #59  #60  #61  #62  #63
[    4.811005] .... node   #8, CPUs:    #64  #65  #66  #67  #68  #69  #70  #71
[    5.421006] .... node   #9, CPUs:    #72  #73  #74  #75  #76  #77  #78  #79
[    6.032005] .... node  #10, CPUs:    #80  #81  #82  #83  #84  #85  #86  #87
[    6.648006] .... node  #11, CPUs:    #88  #89  #90  #91  #92  #93  #94  #95
[    7.262005] .... node  #12, CPUs:    #96  #97  #98  #99 #100 #101 #102 #103
[    7.865005] .... node  #13, CPUs:   #104 #105 #106 #107 #108 #109 #110 #111
[    8.466005] .... node  #14, CPUs:   #112 #113 #114 #115 #116 #117 #118 #119
[    9.073006] .... node  #15, CPUs:   #120 #121 #122 #123 #124 #125 #126 #127
[    9.679901] x86: Booted up 16 nodes, 128 CPUs

and drop useless elements.

Change num_digits() to hpa's division-avoiding, cell-phone-typed
version which he went at great lengths and pains to submit on a
Saturday evening.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: huawei.libin@huawei.com
Cc: wangyijing@huawei.com
Cc: fenghua.yu@intel.com
Cc: guohanjun@huawei.com
Cc: paul.gortmaker@windriver.com
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20130930095624.GB16383@pd.tnic
Signed-off-by: Ingo Molnar <mingo@kernel.org>
a17bce4
Stephen Warren swarren referenced this pull request from a commit in swarren/linux-tegra
Andrew Morton initramfs-support-initramfs-that-is-more-than-2g-checkpatch-fixes
WARNING: quoted string split across lines
#60: FILE: fs/isofs/compress.c:163:
 					       " page idx = %d, bh idx = %d,"
+					       " avail_in = %ld,"

WARNING: quoted string split across lines
#61: FILE: fs/isofs/compress.c:164:
+					       " avail_in = %ld,"
+					       " avail_out = %ld\n",

WARNING: missing space after return type
#76: FILE: include/linux/decompress/bunzip2.h:5:
+	    long(*fill)(void*, unsigned long),

WARNING: missing space after return type
#77: FILE: include/linux/decompress/bunzip2.h:6:
+	    long(*flush)(void*, unsigned long),

WARNING: missing space after return type
#94: FILE: include/linux/decompress/generic.h:5:
+			      long(*fill)(void*, unsigned long),

WARNING: missing space after return type
#95: FILE: include/linux/decompress/generic.h:6:
+			      long(*flush)(void*, unsigned long),

WARNING: missing space after return type
#122: FILE: include/linux/decompress/inflate.h:5:
+	   long(*fill)(void*, unsigned long),

WARNING: missing space after return type
#123: FILE: include/linux/decompress/inflate.h:6:
+	   long(*flush)(void*, unsigned long),

WARNING: missing space after return type
#140: FILE: include/linux/decompress/unlz4.h:5:
+	long(*fill)(void*, unsigned long),

WARNING: missing space after return type
#141: FILE: include/linux/decompress/unlz4.h:6:
+	long(*flush)(void*, unsigned long),

WARNING: missing space after return type
#158: FILE: include/linux/decompress/unlzma.h:5:
+	   long(*fill)(void*, unsigned long),

WARNING: missing space after return type
#159: FILE: include/linux/decompress/unlzma.h:6:
+	   long(*flush)(void*, unsigned long),

WARNING: missing space after return type
#177: FILE: include/linux/decompress/unlzo.h:5:
+	long(*fill)(void*, unsigned long),

WARNING: missing space after return type
#178: FILE: include/linux/decompress/unlzo.h:6:
+	long(*flush)(void*, unsigned long),

WARNING: please, no spaces at the start of a line
#210: FILE: include/linux/zlib.h:86:
+    uLong     avail_in;  /* number of bytes available at next_in */$

WARNING: please, no spaces at the start of a line
#215: FILE: include/linux/zlib.h:90:
+    uLong     avail_out; /* remaining free space at next_out */$

WARNING: __initdata should be placed after count
#259: FILE: init/initramfs.c:177:
+static __initdata unsigned long count;

WARNING: __initdata should be placed after remains
#268: FILE: init/initramfs.c:189:
+static __initdata long remains;

WARNING: missing space after return type
#385: FILE: lib/decompress_bunzip2.c:679:
+			long(*fill)(void*, unsigned long),

WARNING: missing space after return type
#386: FILE: lib/decompress_bunzip2.c:680:
+			long(*flush)(void*, unsigned long),

WARNING: missing space after return type
#401: FILE: lib/decompress_bunzip2.c:747:
+			long(*fill)(void*, unsigned long),

WARNING: missing space after return type
#402: FILE: lib/decompress_bunzip2.c:748:
+			long(*flush)(void*, unsigned long),

WARNING: missing space after return type
#427: FILE: lib/decompress_inflate.c:37:
+		       long(*fill)(void*, unsigned long),

WARNING: missing space after return type
#428: FILE: lib/decompress_inflate.c:38:
+		       long(*flush)(void*, unsigned long),

WARNING: Unnecessary space before function pointer arguments
#456: FILE: lib/decompress_unlz4.c:35:
+				long (*fill) (void *, unsigned long),

WARNING: Unnecessary space before function pointer arguments
#457: FILE: lib/decompress_unlz4.c:36:
+				long (*flush) (void *, unsigned long),

WARNING: missing space after return type
#479: FILE: lib/decompress_unlz4.c:179:
+			      long(*fill)(void*, unsigned long),

WARNING: missing space after return type
#480: FILE: lib/decompress_unlz4.c:180:
+			      long(*flush)(void*, unsigned long),

WARNING: missing space after return type
#529: FILE: lib/decompress_unlzma.c:283:
+	long(*flush)(void*, unsigned long);

WARNING: missing space after return type
#541: FILE: lib/decompress_unlzma.c:538:
+			      long(*fill)(void*, unsigned long),

WARNING: missing space after return type
#542: FILE: lib/decompress_unlzma.c:539:
+			      long(*flush)(void*, unsigned long),

WARNING: missing space after return type
#557: FILE: lib/decompress_unlzma.c:671:
+			      long(*fill)(void*, unsigned long),

WARNING: missing space after return type
#558: FILE: lib/decompress_unlzma.c:672:
+			      long(*flush)(void*, unsigned long),

WARNING: Unnecessary space before function pointer arguments
#586: FILE: lib/decompress_unlzo.c:112:
+				long (*fill) (void *, unsigned long),

WARNING: Unnecessary space before function pointer arguments
#587: FILE: lib/decompress_unlzo.c:113:
+				long (*flush) (void *, unsigned long),

total: 0 errors, 35 warnings, 479 lines checked

./patches/initramfs-support-initramfs-that-is-more-than-2g.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
c923ec1
Andy Shevchenko andy-shev referenced this pull request from a commit in andy-shev/linux
Andrew Morton fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open-chec…
…kpatch-fixes

WARNING: Missing a blank line after declarations
#77: FILE: fs/proc/task_mmu.c:246:
+		int err = PTR_ERR(priv->mm);
+		seq_release_private(inode, file);

total: 0 errors, 1 warnings, 94 lines checked

./patches/fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
c4265e9
Andrey Ryabinin aryabinin referenced this pull request from a commit in aryabinin/linux
Andrew Morton fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open-chec…
…kpatch-fixes

WARNING: Missing a blank line after declarations
#77: FILE: fs/proc/task_mmu.c:246:
+		int err = PTR_ERR(priv->mm);
+		seq_release_private(inode, file);

total: 0 errors, 1 warnings, 94 lines checked

./patches/fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
d8644e7
Stephen Warren swarren referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Andy Shevchenko andy-shev referenced this pull request from a commit in andy-shev/linux
Andrew Morton fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open-chec…
…kpatch-fixes

WARNING: Missing a blank line after declarations
#77: FILE: fs/proc/task_mmu.c:246:
+		int err = PTR_ERR(priv->mm);
+		seq_release_private(inode, file);

total: 0 errors, 1 warnings, 94 lines checked

./patches/fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
c354ac6
Andrey Ryabinin aryabinin referenced this pull request from a commit in aryabinin/linux
Andrew Morton fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open-chec…
…kpatch-fixes

WARNING: Missing a blank line after declarations
#77: FILE: fs/proc/task_mmu.c:246:
+		int err = PTR_ERR(priv->mm);
+		seq_release_private(inode, file);

total: 0 errors, 1 warnings, 94 lines checked

./patches/fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
aff9104
Naoya Horiguchi Naoya-Horiguchi referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Konstantin Khlebnikov koct9i referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Andrey Ryabinin aryabinin referenced this pull request from a commit in aryabinin/linux
Andrew Morton fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open-chec…
…kpatch-fixes

WARNING: Missing a blank line after declarations
#77: FILE: fs/proc/task_mmu.c:246:
+		int err = PTR_ERR(priv->mm);
+		seq_release_private(inode, file);

total: 0 errors, 1 warnings, 94 lines checked

./patches/fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
969c319
ddstreet ddstreet referenced this pull request from a commit in ddstreet/linux
Andrew Morton fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open-chec…
…kpatch-fixes

WARNING: Missing a blank line after declarations
#77: FILE: fs/proc/task_mmu.c:246:
+		int err = PTR_ERR(priv->mm);
+		seq_release_private(inode, file);

total: 0 errors, 1 warnings, 94 lines checked

./patches/fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
f58b75f
Konstantin Khlebnikov koct9i referenced this pull request from a commit in koct9i/linux
Andrew Morton fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open-chec…
…kpatch-fixes

WARNING: Missing a blank line after declarations
#77: FILE: fs/proc/task_mmu.c:246:
+		int err = PTR_ERR(priv->mm);
+		seq_release_private(inode, file);

total: 0 errors, 1 warnings, 94 lines checked

./patches/fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
8ead0ee
Tomasz Figa tom3q referenced this pull request from a commit in tom3q/linux
Andrew Morton fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open-chec…
…kpatch-fixes

WARNING: Missing a blank line after declarations
#77: FILE: fs/proc/task_mmu.c:246:
+		int err = PTR_ERR(priv->mm);
+		seq_release_private(inode, file);

total: 0 errors, 1 warnings, 94 lines checked

./patches/fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
846d7a1
Andrey Ryabinin aryabinin referenced this pull request from a commit in aryabinin/linux
Andrew Morton fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open-chec…
…kpatch-fixes

WARNING: Missing a blank line after declarations
#77: FILE: fs/proc/task_mmu.c:246:
+		int err = PTR_ERR(priv->mm);
+		seq_release_private(inode, file);

total: 0 errors, 1 warnings, 94 lines checked

./patches/fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1144066
bengal bengal referenced this pull request from a commit in bengal/linux
Andrew Morton fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open-chec…
…kpatch-fixes

WARNING: Missing a blank line after declarations
#77: FILE: fs/proc/task_mmu.c:246:
+		int err = PTR_ERR(priv->mm);
+		seq_release_private(inode, file);

total: 0 errors, 1 warnings, 94 lines checked

./patches/fs-proc-task_mmuc-shift-mm_access-from-m_start-to-proc_maps_open.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
8bcf545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 7, 2014
  1. Colin

    Fixed typo in comment

    kiteflyingmonkey authored
    Changed "then" to "than"
    No functional change
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  include/linux/time.h
2  include/linux/time.h
View
@@ -99,7 +99,7 @@ static inline bool timespec_valid(const struct timespec *ts)
/* Dates before 1970 are bogus */
if (ts->tv_sec < 0)
return false;
- /* Can't have more nanoseconds then a second */
+ /* Can't have more nanoseconds than a second */
if ((unsigned long)ts->tv_nsec >= NSEC_PER_SEC)
return false;
return true;
Something went wrong with that request. Please try again.