Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Jan 5, 2012
  1. @dirkhh

    Oddly, finishing a sample doesn't require a sample

    dirkhh authored
    So let's not pass it around
    Signed-off-by: Dirk Hohndel <>
Commits on Dec 7, 2011
  1. @dirkhh

    Add typical 0 to 5 star rating for dives

    dirkhh authored
    This works ok-ish, but doesn't allow us to click on the stars and edit
    them in the divelist, which a user might expect to be able to do - in
    most "star rating UIs" you simply click on the n-th star to set that
    rating. Here you need to edit the dive and pick the rating from a drop
    down menu.
    Minor oddity: you can actually (if you force it) write anything you want
    into the star rating. But anything that isn't one of the predefined
    strings simply results in a zero star rating.
    Overall the UI feels a bit... forced. But I think this is quite useful
    Signed-off-by: Dirk Hohndel <>
Commits on Nov 2, 2011
  1. @dirkhh

    Add Info & Stats page to the notebook

    dirkhh authored
    This provides the relevant information for the currently selected dive
    plus a bunch of statistics over all dives in the dive_table.
    The visual design has lots of room for improvement
    - right now the different fields change size
    - it might be nice to have a more modern look for the entries
    - the O2/He field is odd - for most divers the He value will
      always be 0, so maybe we should only show He if there's at least one
      dive that uses He? Also, we simply do a comma separated list of gases
      for all the tanks used
    Signed-off-by: Dirk Hohndel <>
  2. @dirkhh

    Even more places with pressure and volume conversions

    dirkhh authored
    Amazing at how many spots we are re-implementing the wheel.
    Signed-off-by: Dirk Hohndel <>
  3. @dirkhh

    Further cleanup of pressure and volume conversions

    dirkhh authored
    I'm amazed at how many spots we were doing conversions - some of them
    subtly different than others.
    Signed-off-by: Dirk Hohndel <>
  4. @dirkhh

    Use unit functions to get column headers, add unit function for pressure

    dirkhh authored
    Finally getting more consistent overall in how we convert between the
    different units and how we decide which units to display.
    Signed-off-by: Dirk Hohndel <>
  5. @dirkhh

    More consistency improvements

    dirkhh authored
    Treat SAC and OTU consistently:
    - SAC is now a member of struct dive
    - it's calculated / populated at the same time with a helper function with
      consistent API
    Create get_volume_units function that returns volumes (e.g. used in SAC
    rates) based on preferred units - make sure we have these conversions just
    once in the code.
    Signed-off-by: Dirk Hohndel <>
  6. @dirkhh

    Add new helper function to get temperature and unit

    dirkhh authored
    Designed along the lines of get_depth_units - except we don't define a
    specific number of digits to show.
    Use this in the one spot we need it right now in profile.c
    Signed-off-by: Dirk Hohndel <>
Commits on Oct 29, 2011
  1. @dirkhh

    Use Registry on Windows to store preferences

    dirkhh authored
    No change at all to non-Windows builds.
    Everything seems to work with preferences - but only tested on Win7
    Remaining issue: displaying an icon (or the logo in the About dialog)
    Signed-off-by: Dirk Hohndel <>
Commits on Oct 25, 2011
  1. @dirkhh

    Add menu item and dialog to select which events to display

    dirkhh authored
    Right now they are displayed in one hbox which doesn't work if you have
    many events - but the code itself works and correctly toggles the events
    on and off.
    Signed-off-by: Dirk Hohndel <>
  2. @dirkhh

    Remember the event names as we encounter them

    dirkhh authored
    First step to being able to filter the events that we display in the
    profile. We could (in theory) walk all the dives in the divelist when we
    need this data, but it seems much more convenient to have them in an array
    in one place.
    Signed-off-by: Dirk Hohndel <>
Commits on Oct 5, 2011
  1. @dirkhh

    Add XML file import back and treat open and import differently

    dirkhh authored
    Open (or adding a file name on the command line) means that this is just
    one of the files that you consider part of your dive history. So dives
    don't get automagically numbered and the dive_list is not considered
    "changed" just because another file was opened.
    Import (or adding a file on the command line after --import) means that
    you are importing the content of this file to your dive history. So if the
    imported file has un-numbered dives that are newer than everything else,
    those get correctly renumbered. And importing marks the dive_list as
    Signed-off-by: Dirk Hohndel <>
Commits on Oct 3, 2011
  1. @dirkhh

    Remove the ability to 'Import' .SDA files

    dirkhh authored
    We can instead 'Open' these files as they are just bastardized XML files.
    This gets us back to a more consistent point where 'Import' gets data
    directly from the dive computer (and hopefully soon we will add the
    ability to load a dive directly from a uemis SDA to libdivecomputer),
    and 'Open' loads a file from the filesystem of the computer we are
    running on (this last sentence phrased so awkwardly as the uemis Zurich
    SDA is a computer and presents a file system when connected via USB - it
    just doesn't have the dive data in an accessible format in that file
    As a bonus we get to throw away quite a bit of code (the uemis specific
    file handling, mini-XML parser with helper functions, the file open dialog
    in the importer). Yay!
    Signed-off-by: Dirk Hohndel <>
Commits on Sep 22, 2011
  1. @dirkhh

    Add OTU to divelist

    dirkhh authored
    and change OTUs to be tracked as int, not double
    Signed-off-by: Dirk Hohndel <>
  2. @dirkhh

    Calculate OTUs for every dive

    dirkhh authored
    The calculation assumes that the cylinderindex in each sample tells us
    which PO2 the dive was breathing at that time. This needs to be verified
    with dives where there is an actual gas switch.
    No idea where to display them, yet. Far fewer people will care about this
    than care about SAC - does this still rate a spot in the dive_list?
    I guess I could make it part of the dive_info - but it's not editable.
    It doesn't seem to fit with the equipment page (even though this is the
    one editable field that is related - nitrox %)
    Signed-off-by: Dirk Hohndel <>
Commits on Sep 21, 2011
  1. @dirkhh

    Use the last (or only) filename on command line as default for saving

    dirkhh authored
    Signed-off-by: Dirk Hohndel <>
Commits on Sep 20, 2011
  1. @dirkhh

    Separate out the UI from the program logic

    dirkhh authored
    The following are UI toolkit specific:
    gtk-gui.c   - overall layout, main window of the UI
    divelist.c  - list of dives subsurface maintains
    equipment.c - equipment / tank information for each dive
    info.c      - detailed dive info
    print.c     - printing
    The rest is independent of the UI:
    main.c i    - program frame
    dive.c i    - creates and maintaines the internal dive list structure
    save-xml.c  - interface with dive computers and the XML files
    profile.c   - creates the data for the profile and draws it using cairo
    This commit should contain NO functional changes, just moving code around
    and a couple of minor abstractions.
    Signed-off-by: Dirk Hohndel <>
Commits on Sep 16, 2011
  1. @dirkhh

    Show tank / nitrox / air consumption information in the info_frame

    dirkhh authored
    Even though we go down to an 8pt font the info_frame changes size when the
    air info is added. I don't like this but want to see how Linus would like
    this resolved before going overboard.
    Minor tweaks to the formating (we don't need two decimals when printing
    the liters of air consumed).
    This patch does NOT remove the plot of the air information in the profile
    graph. I think we want to remove that once we like the text where it is,
    but I wanted to do one thing at a time.
    Signed-off-by: Dirk Hohndel <>
Something went wrong with that request. Please try again.