avoid issues with unicode error messages

toscawidgets · Jul 18, 2012 · b5a314d · b5a314d
1 parent bc509ca
commit b5a314d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/tests/test_validation.py b/tests/test_validation.py
@@ -78,6 +78,16 @@ def test_catch_errors(self):
         except twc.ValidationError:
             pass
 
+    def test_unicode_catch_errors(self):
+        try:
+            formencode.api.set_stdtranslation(languages=['tr'])
+            twc.validation.catch_errors(lambda s, x: formencode.validators.Int.to_python(x))(None, 'x')
+            assert(False)
+        except twc.ValidationError:
+            pass
+        finally:
+            formencode.api.set_stdtranslation(languages=['en'])
+
     def test_unflatten(self):
         assert(twc.validation.unflatten_params({'a':1, 'b:c':2}) ==
             {'a':1, 'b':{'c':2}})

diff --git a/tw2/core/validation.py b/tw2/core/validation.py
@@ -94,9 +94,10 @@ def wrapper(self, *args, **kw):
             d = fn(self, *args, **kw)
             return d
         except catch, e:
+            e_msg = unicode(e)
             if self:
-                self.error_msg = str(e)
-            raise ValidationError(str(e), widget=self)
+                self.error_msg = e_msg
+            raise ValidationError(e_msg, widget=self)
     return wrapper