From 71b33b5bc073715f7ca9a8a715835ac4ed9ae1ba Mon Sep 17 00:00:00 2001 From: Ralph Bean Date: Thu, 24 May 2012 15:35:01 -0400 Subject: [PATCH] Stop twf.Spacer from injecting None key in validated data. --- tests/test_widgets.py | 12 ++++++++++++ tw2/forms/widgets.py | 3 +++ 2 files changed, 15 insertions(+) diff --git a/tests/test_widgets.py b/tests/test_widgets.py index 1ac0de3..5099184 100644 --- a/tests/test_widgets.py +++ b/tests/test_widgets.py @@ -494,6 +494,18 @@ class TestSpacer(WidgetTest): attrs = {} expected = """
""" + +def test_spacer_validation(): + """ Test that spacers don't inject None keys in validated data. """ + + class SomeForm(TableForm): + some_id = HiddenField + space = Spacer + + data = SomeForm.validate({}) + assert None not in data + + class TestLabel(WidgetTest): widget = Label attrs = {'text':'something'} diff --git a/tw2/forms/widgets.py b/tw2/forms/widgets.py index 34c6ced..9834117 100755 --- a/tw2/forms/widgets.py +++ b/tw2/forms/widgets.py @@ -614,6 +614,9 @@ class Spacer(FormField): id = None label = None + def _validate(self, value, state=None): + return twc.EmptyField + class Label(twc.Widget): """