Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI 2 #80

Merged
merged 40 commits into from Aug 17, 2017

Conversation

@toshimaru
Copy link
Owner

commented Aug 12, 2017

closes #77

  • circle.yml => .circleci/config.yml (CircleCI2 馃帀 )
  • Run rpsec:install again
  • Rspec.describe with type addition

toshimaru added some commits Aug 12, 2017


# Restore bundle cache
- type: cache-restore
key: rails-demo-{{ checksum "Gemfile.lock" }}

This comment has been minimized.

Copy link
@toshimaru

toshimaru Aug 14, 2017

Author Owner

rename key

- MYSQL_ROOT_HOST=%
steps:
- checkout

This comment has been minimized.

Copy link
@toshimaru

toshimaru Aug 14, 2017

Author Owner

Install PhantomJS.

- run: bundle exec rspec

- store_artifacts:
path: coverage

This comment has been minimized.

Copy link
@toshimaru

toshimaru Aug 14, 2017

Author Owner

save capybara screenshot

@toshimaru toshimaru force-pushed the circleci2 branch from 72f62cb to 15c7d67 Aug 14, 2017

@toshimaru toshimaru force-pushed the circleci2 branch from d57b18e to dee9a4a Aug 14, 2017

toshimaru added some commits Aug 14, 2017

Install phantomjs-prebuilt instead
Package renamed to phantomjs-prebuilt. Please update 'phantomjs'
package references to 'phantomjs-prebuilt'
wip
wip

toshimaru added some commits Aug 15, 2017

@@ -1,6 +1,6 @@
require 'rails_helper'

describe ApplicationController do
RSpec.describe ApplicationController do

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 15, 2017

Block has too many lines. [31/25]

@@ -1,6 +1,6 @@
require 'rails_helper'

describe "UserPages" do
RSpec.describe "UserPages" do

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 15, 2017

Block has too many lines. [170/25]

@@ -1,6 +1,6 @@
require 'rails_helper'

describe "Tweet pages" do
RSpec.describe "Tweet pages" do

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 15, 2017

Block has too many lines. [42/25]

@@ -1,6 +1,6 @@
require 'rails_helper'

describe "Static Pages" do
RSpec.describe "Static Pages" do

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 15, 2017

Block has too many lines. [27/25]

@@ -1,6 +1,6 @@
require 'rails_helper'

describe "Authentication" do
RSpec.describe "Authentication" do

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 15, 2017

Block has too many lines. [92/25]

@@ -1,6 +1,6 @@
require 'rails_helper'

describe UsersController do
RSpec.describe UsersController do

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 15, 2017

Block has too many lines. [68/25]

config.shared_context_metadata_behavior = :apply_to_host_groups

# The settings below are suggested to provide a good initial experience
# with RSpec, but feel free to customize to your heart's content.

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 15, 2017

Incorrect indentation detected (column 0 instead of 2).

@@ -1,2 +1,94 @@
# This file was generated by the `rails generate rspec:install` command. Conventionally, all

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 15, 2017

Missing magic comment # frozen_string_literal: true.
Line is too long. [92/80]

# directory. Alternatively, in the individual `*_spec.rb` files, manually
# require only the support files necessary.
#
Dir[Rails.root.join('spec/support/**/*.rb')].each { |f| require f }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 15, 2017

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.


require "capybara/poltergeist"
SimpleCov.start 'rails'

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 15, 2017

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

SimpleCov.start 'rails'

require 'rspec/rails'
require 'capybara/poltergeist'

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 15, 2017

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

require File.expand_path('../../config/environment', __FILE__)
# Prevent database truncation if the environment is production
abort("The Rails environment is running in production mode!") if Rails.env.production?
require 'rspec/rails'

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 15, 2017

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

ENV['RAILS_ENV'] ||= 'test'
require File.expand_path('../../config/environment', __FILE__)
# Prevent database truncation if the environment is production
abort("The Rails environment is running in production mode!") if Rails.env.production?

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 15, 2017

Line is too long. [86/80]

require 'spec_helper'
require File.expand_path("../../config/environment", __FILE__)
ENV['RAILS_ENV'] ||= 'test'
require File.expand_path('../../config/environment', __FILE__)

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 15, 2017

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

require 'spec_helper'
require File.expand_path("../../config/environment", __FILE__)
ENV['RAILS_ENV'] ||= 'test'

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 15, 2017

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@@ -2,7 +2,7 @@

require 'rails_helper'

describe User do
RSpec.describe User do

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 15, 2017

Block has too many lines. [131/25]

toshimaru added some commits Aug 15, 2017

@@ -1,7 +1,6 @@
require 'rails_helper'

describe ApplicationController do

RSpec.describe ApplicationController, type: :controller do

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 16, 2017

Block has too many lines. [31/25]

require 'rails_helper'

describe User do
RSpec.describe User, type: :model do

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 16, 2017

Block has too many lines. [131/25]

@@ -1,7 +1,6 @@
require 'rails_helper'

describe "Authentication" do

RSpec.describe "Authentication", type: :feature do

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 16, 2017

Block has too many lines. [92/25]

toshimaru added some commits Aug 16, 2017

@toshimaru toshimaru merged commit 13a5ff9 into master Aug 17, 2017

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
ci/sideci Meow! No issues found. It's clean code!
Details
codeclimate/coverage 66.53% (-33.5%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
hound 17 violations found.

@toshimaru toshimaru deleted the circleci2 branch Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.