Skip to content

ci: oidc 3 #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2025
Merged

ci: oidc 3 #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2d5579
ci: update release workflow for package publishing and git configuration
manudeli Oct 15, 2025
d588c91
chore: update CODEOWNERS to include new user @kimyouknow
manudeli Oct 15, 2025
fbb4561
chore: update issue templates and release workflow to assign new user…
manudeli Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* @pumpkiinbell @seungrodotlee @choi2021
* @kimyouknow @pumpkiinbell @choi2021
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Bug Report
about: Help us improve react-simplikit by reporting a bug
title: '[BUG] '
labels: 'bug'
assignees: 'seungrodotlee, pumpkiinbell, choi2021'
assignees: 'kimyouknow, pumpkiinbell, choi2021'
---

**Describe the bug**
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Documentation
about: Help us improve react-simplikit's documentation
title: '[DOCS] '
labels: 'documentation'
assignees: 'seungrodotlee, pumpkiinbell, choi2021'
assignees: 'kimyouknow, pumpkiinbell, choi2021'
---

**Location of the documentation**
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Feature Request
about: Suggest an idea for react-simplikit
title: '[FEATURE] '
labels: 'enhancement'
assignees: 'seungrodotlee, pumpkiinbell, choi2021'
assignees: 'kimyouknow, pumpkiinbell, choi2021'
---

**Is your feature request related to a problem? Please describe.**
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/other.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Other Issue
about: Create a report for issues that don't fit the above templates
title: ''
labels: 'question'
assignees: 'seungrodotlee, pumpkiinbell, choi2021'
assignees: 'kimyouknow, pumpkiinbell, choi2021'
---

**Describe the issue**
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,14 @@ jobs:
run: yarn version patch

- name: Publish package
run: yarn npm publish
run: yarn npm publish --provenance --access public
env:
NODE_OPTIONS: --max-old-space-size=8192

- name: Set git username with email
run: |
git config user.name "seungrodotlee"
git config user.email "seungrodotlee@gmail.com"
git config user.name "김윤호 yunho"
git config user.email "kimyouknow9@gmail.com"
Comment on lines +75 to +76
Copy link

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid hard-coding a personal name/email in CI. It exposes personal information in build logs/artifacts and causes tags/commits to be authored under a human identity. Prefer using the GitHub Actions bot identity or derive from the workflow actor with a noreply address. For example:

git config user.name "github-actions[bot]"
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"

or:

git config user.name "${{ github.actor }}"
git config user.email "${{ github.actor }}@users.noreply.github.com"

Suggested change
git config user.name "김윤호 yunho"
git config user.email "kimyouknow9@gmail.com"
git config user.name "github-actions[bot]"
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"

Copilot uses AI. Check for mistakes.

- name: Tag version
run: |
Expand Down Expand Up @@ -147,5 +147,5 @@ jobs:
title: 'docs(${{ needs.get-diffs.outputs.result }}): auto-generated docs'
body: 'This PR includes documentation updates for: ${{ needs.get-diffs.outputs.result }}'
author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
reviewers: seungrodotlee,pumpkiinbell,choi2021
reviewers: kimyouknow,pumpkiinbell,choi2021
commit-message: 'Generate docs for ${{ needs.get-diffs.outputs.result }}'
Loading