Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow construction of a CSV Reader with none-default separators, quotes,... #2

Merged
merged 1 commit into from May 5, 2013

Conversation

Projects
None yet
2 participants
Contributor

mcarolan commented Mar 23, 2013

... or number of lines to skip before reading.

Added these as new construction methods with defaulted parameters. Could not add the defaulted parameters to original open methods as defaulted can only be given to methods with no additional overloads

Martin Carolan Allow construction of a CSV Reader with none-default separators, quot…
…es, or number of lines to skip before reading.

Added these as new construction methods with defaulted parameters. Could not add the defaulted parameters to original open methods as defaulted  can only be given to methods with no additional overloads
405e576
Owner

tototoshi commented May 5, 2013

Thanks, I will merge this.
I'm thinking about renaming #openFromFile to #fromFile to follow the naming convention of Scala standard library.

@tototoshi tototoshi added a commit that referenced this pull request May 5, 2013

@tototoshi tototoshi Merge pull request #2 from mcarolan/pullreq405e576d8
Allow construction of a CSV Reader with none-default separators, quotes,...
747dd5e

@tototoshi tototoshi merged commit 747dd5e into tototoshi:master May 5, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment