-
Notifications
You must be signed in to change notification settings - Fork 1
Test Dropdown Focus Management && Bugfixes #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 70.07% 77.95% +7.87%
==========================================
Files 8 8
Lines 127 127
Branches 30 30
==========================================
+ Hits 89 99 +10
+ Misses 38 28 -10
Continue to review full report at Codecov.
|
|
@marcus-herrmann Here are the bug fixes: 2e2f4ef and 1c06de6 |
|
I always don’t know if I fix bugs because they are bugs or if they are only «bugs» in Storybook. But I think the focus management thing is a real bug. |
|
@marcus-herrmann Can I merge this? |
@ovlb From the start on I tried to test focus management, but it always failed.
Leaving the approach below as a note-to-oneself / a how-to for improving existing and writing new tests.