Skip to content

Conversation

@marcus-herrmann
Copy link
Collaborator

@ovlb From the start on I tried to test focus management, but it always failed.

Leaving the approach below as a note-to-oneself / a how-to for improving existing and writing new tests.

@codecov
Copy link

codecov bot commented Feb 2, 2020

Codecov Report

Merging #69 into master will increase coverage by 7.87%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   70.07%   77.95%   +7.87%     
==========================================
  Files           8        8              
  Lines         127      127              
  Branches       30       30              
==========================================
+ Hits           89       99      +10     
+ Misses         38       28      -10     
Impacted Files Coverage Δ
packages/dropdown/src/index.vue 76.27% <25.00%> (+16.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d520fc...edb5f12. Read the comment docs.

@ovlb ovlb added the component:dropdown Issues regarding @tournant/dropdown label Mar 6, 2020
@ovlb
Copy link
Member

ovlb commented Mar 6, 2020

@marcus-herrmann Here are the bug fixes: 2e2f4ef and 1c06de6

@ovlb ovlb marked this pull request as ready for review March 6, 2020 19:52
@ovlb
Copy link
Member

ovlb commented Mar 6, 2020

I always don’t know if I fix bugs because they are bugs or if they are only «bugs» in Storybook. But I think the focus management thing is a real bug.

@ovlb ovlb changed the title Start testing focus state on Dropdown Test Dropdown Focus Management && Bugfixes Mar 6, 2020
@ovlb
Copy link
Member

ovlb commented Apr 12, 2020

@marcus-herrmann Can I merge this?

@marcus-herrmann
Copy link
Collaborator Author

@ovlb I can't really speak for everything but commit fd7bab7, but in this case, yes.

@ovlb ovlb merged commit f31c90c into master Apr 15, 2020
@ovlb ovlb deleted the feature/dropdown-test-improvement branch April 15, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:dropdown Issues regarding @tournant/dropdown

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants