Skip to content

Feat: ARMv7 support #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 27, 2020
Merged

Feat: ARMv7 support #14

merged 6 commits into from
Oct 27, 2020

Conversation

timfish
Copy link
Contributor

@timfish timfish commented Jun 23, 2020

  • Allows libffi-rs to build for Raspberry Pi and other ARMv7 targets that don't have longdouble
  • Fixes a failing test on Windows

@tov
Copy link
Owner

tov commented Jun 25, 2020

Thanks for the PR! This seems like a good thing to fix, but I wonder if there’s a simple way we could make it detect which types are available rather than having to specify the ABIs explicitly in the source…

@timfish
Copy link
Contributor Author

timfish commented Jun 28, 2020

I wonder if there’s a simple way we could make it detect which types are available

I'm open to suggestions but this is the only way I can think of!

@timfish
Copy link
Contributor Author

timfish commented Sep 1, 2020

It would be great to find a way to get something like this merged. I would like to publish a crate which depends on libffi but it won't build on Raspberry Pi and that's a platform we want to target.

I think it's safe to reduce the conditional compilation down to:

 #[cfg(not(target_arch = "arm"))]

The only other way I can think to do this is to parse the code generation output of libffi-sys and set a feature flag. It seems like this could be a lot more fragile that simply disabling longdouble support for arm. What other platforms don't support longdouble? Do we even have access to any of those platforms to test?

@yorickpeterse yorickpeterse mentioned this pull request Oct 19, 2020
4 tasks
@yorickpeterse
Copy link
Collaborator

@timfish Now that 1.0.0 is released, could you rebase this MR and adjust if needed? I'd love to have these changes merged in 😄

@yorickpeterse yorickpeterse merged commit 5378608 into tov:master Oct 27, 2020
@yorickpeterse
Copy link
Collaborator

@timfish Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants