fix content-length calculation on range requests #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
requested changes
Mar 8, 2022
davidpdrsn
reviewed
Mar 8, 2022
|
I see there are a few tests running on both head-requests and range-requests checking the content-length and that you fixed the test that should return something other than the full file size. It seems that I both wrote a bug and a bugged test to go with it. Really nice catch, thank you! |
|
I think this closes #197. I’ll try to test it out later |
davidpdrsn
approved these changes
Mar 9, 2022
There was a problem hiding this comment.
I think this looks good. Will wait for @adumbidiot to report back before merging.
|
Just tested, this fixes #197 |
|
Great! I think I'll backport this to 0.2.x tomorrow while we work on 0.3. |
davidpdrsn
added a commit
that referenced
this pull request
Mar 11, 2022
* fix content-length calculation on range requests * changelog Co-authored-by: David Pedersen <david.pdrsn@gmail.com>
davidpdrsn
added a commit
that referenced
this pull request
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello,
content-length response header on range requests should represent the length of the returned range, not the length of the whole file.
more explanations here: https://developer.mozilla.org/en-US/docs/Web/HTTP/Range_requests
Best regards.