Properly clone the request for ServeDir's fallback #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
approved these changes
Apr 28, 2022
davidpdrsn
approved these changes
Apr 28, 2022
|
I'll make a new release tomorrow or later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I tried to chain two ServeDir (one being the fallback for the other) and got confused why it could not find files from the second one.
It turns out, the request passed to the fallback service was not cloned properly from the original request.
Solution
Renamed the fallback request variable name to properly clone the method/uri/headers/extensions from the original request, and not from itself.
I modified the fallback test to include the URI path in the response and check if it matches.