Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly identify gRPC requests in default on_response callback #278

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

jdahlq
Copy link
Contributor

@jdahlq jdahlq commented Jul 2, 2022

Fixes #277

@davidpdrsn davidpdrsn changed the title use grpc status instead of html status in grpc-web on_response trace Correctly identify gRPC requests in default on_response callback Jul 2, 2022
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Wanna add a line to changelog as well?

@jdahlq
Copy link
Contributor Author

jdahlq commented Jul 2, 2022

Thanks!

Wanna add a line to changelog as well?

Sure thing, done!

Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidpdrsn davidpdrsn merged commit 9b18aa7 into tower-rs:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on_response trace uses HTTP status code instead of gRPC code for grpc-web
2 participants