change NewService to MakeService<Target, Request> #114
Conversation
|
This also changed One place where this was weird was with |
tower-reconnect/src/lib.rs
Outdated
| where | ||
| T: NewService<Request>, | ||
| T: MakeService<Ctx, Request>, | ||
| Ctx: Clone, |
There was a problem hiding this comment.
I'm thinking that instead of requiring Clone here, it'd be more flexible if the bounds were T: MakeService<&Ctx, Request>. Then, if the new Service needs a clone, it can make one, but it's otherwise not wasted.
|
I'd like to see something in the docs about what |
|
I explored if something like this could be used in hyper (allowing user's to grab the remote address) (and while not being a breaking change yet), and it works: hyperium/hyper@94cc806 Though I had to some nasty crap to get |
tower-reconnect/src/lib.rs
Outdated
| { | ||
| new_service: T, | ||
| state: State<T, Request>, | ||
| context: Ctx, |
There was a problem hiding this comment.
If we are bike shedding, I prefer "target" over "context". I feel that it makes the intent a bit more clear.
tower-reconnect/src/lib.rs
Outdated
| @@ -23,47 +24,47 @@ pub enum Error<T, U> { | |||
| NotReady, | |||
| } | |||
|
|
|||
| pub struct ResponseFuture<T, Request> | |||
| pub struct ResponseFuture<T, Ctx, Request> | |||
There was a problem hiding this comment.
I know it is an unrelated change... but can this just be ResponseFuture<T> where T is the inner future?
There was a problem hiding this comment.
Not easily, since the error is mapped by Error::Inner which means the bounds are needed. Perhaps with some better refactoring...
tower-reconnect/src/lib.rs
Outdated
| where | ||
| T: NewService<Request>, | ||
| T: MakeService<Ctx, Request>, | ||
| Ctx: Clone, |
|
Can we 🚢 🇮🇹 ? |
|
Note to self: this affects #119. |
seanmonstar
force-pushed
the
new-service-arg
branch
from
764b5b3
to
19e0193
Compare
seanmonstar
changed the title
|
I'd still like to see some docs for what the |
This currently uses `Target=()`, because I don't know how `Target` is supposed to be used.
This is caused by tower-rs/tower#114, which some tower crates haven't picked up yet. It's necessary to specify a `[replace]` since `[patch]` can't override dependencies with the same source. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
This updates the `tokio-trace-tower` and `tokio-trace-tower-http` compatibility crates to be compatible with tower-rs/tower#114 and tower-rs/tower-h2#42. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
This updates the `tokio-trace-tower` and `tokio-trace-tower-http` compatibility crates to be compatible with tower-rs/tower#114 and tower-rs/tower-h2#42. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
This currently uses `Target=()`, because I don't know how `Target` is supposed to be used.
Builds off the
generic-requestbranch.cc #108