Spawn ready: drives a service's readiness on an executor #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some layers cannot guarantee that they will poll inner services in a timely fashion. For instance, the balancer polls its inner services to check for readiness, but it does so randomly. If its inner service must be polled several times to become ready, e.g., because it's driving the initiation of a TLS connection, then the balancer may not drive the handshake to completion. The `SpawnReady` layer ensures that its inner service is driven to readiness by spawning a background task.
olix0r
commented
May 25, 2019
hawkw
reviewed
May 28, 2019
carllerche
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some layers cannot guarantee that they will poll inner services in a
timely fashion. For instance, the balancer polls its inner services to
check for readiness, but it does so randomly. If its inner service
must be polled several times to become ready, e.g., because it's driving
the initiation of a TLS connection, then the balancer may not drive the
handshake to completion.
The
SpawnReadylayer ensures that its inner service is driven toreadiness by spawning a background task.