Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: array field wouldn't save empty value #145

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

lkoller
Copy link
Contributor

@lkoller lkoller commented Jun 17, 2022

If you cleared the values in an array field the changes were not being persisted

because the array of values was empty and we were using a 'forEach', it would skip that block of code, I added an if to check if the items are empty and set the value to an empty array

Screen.Recording.2022-06-17.at.10.59.03.AM.mov

@lkoller lkoller requested a review from staylorwr June 17, 2022 18:00
@staylorwr staylorwr merged commit ef09ca2 into master Jun 17, 2022
@staylorwr staylorwr deleted the lk/array_field_should_save_empty_value branch June 17, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants