Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Update BooleanGroup for ecto 3.5 #35

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

alexandreaco
Copy link

  • Latest ecto returns a :parameterized type for embedded fields
  • Update BooleanGroup module to handle this new field type
  • Add tests for embedded feature flags on a post

Related to Clubhouse https://app.clubhouse.io/township/story/1394/allow-a-vc-fund-to-turn-off-navigation-items

test/support/schema.exs Outdated Show resolved Hide resolved
lib/ex_teal/fields/boolean_group.ex Outdated Show resolved Hide resolved
* Latest ecto returns a :parameterized type for embedded fields
* Update BooleanGroup module to handle this new field type
* Add tests for embedded feature flags on a post
* Update styles for BooleanGroup detail to use the same styles as the Boolean field
@alexandreaco alexandreaco merged commit 49228f0 into master Nov 4, 2020
@alexandreaco alexandreaco deleted the feature/update-boolean-group branch November 4, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants