Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running tox in --notest mode always succeeds #1097

Closed
webknjaz opened this issue Dec 7, 2018 · 6 comments
Closed

Running tox in --notest mode always succeeds #1097

webknjaz opened this issue Dec 7, 2018 · 6 comments

Comments

@webknjaz
Copy link
Contributor

@webknjaz webknjaz commented Dec 7, 2018

So the problem is that I run tox --notest in the install step in Travis CI and just tox in script.

Now, because there's a deps conflict it traced back and tox printed out an error. But the return code was 0 so travis just folded all output from tox --notest and it looked weirdly broken on the test stage. While the real reason is that it produced a pre-baked venv without crashing the whole thing in the right moment.

Current workaround is to manually parse the output:
https://github.com/ansible/molecule/blob/5f6bcc9/.travis.yml#L338-L341

@asottile
Copy link
Member

@asottile asottile commented Dec 8, 2018

I'm having trouble reproducing, even with the same plugins (tox-venv):

[tox]
skipsdist = true

[testenv]
deps = asottilewat
commands =
    python --version
$ tox -e py27 --notest; echo $?
py27 create: /tmp/x/.tox/py27
py27 installdeps: asottilewat
ERROR: invocation failed (exit code 1), logfile: /tmp/x/.tox/py27/log/py27-1.log
ERROR: actionid: py27
msg: getenv
cmdargs: '/tmp/x/.tox/py27/bin/python -m pip install asottilewat'

Collecting asottilewat
  Could not find a version that satisfies the requirement asottilewat (from versions: )
No matching distribution found for asottilewat

ERROR: could not install deps [asottilewat]; v = InvocationError('/tmp/x/.tox/py27/bin/python -m pip install asottilewat (see /tmp/x/.tox/py27/log/py27-1.log)', 1)
___________________________________ summary ____________________________________
ERROR:   py27: could not install deps [asottilewat]; v = InvocationError('/tmp/x/.tox/py27/bin/python -m pip install asottilewat (see /tmp/x/.tox/py27/log/py27-1.log)', 1)
1

@asottile
Copy link
Member

@asottile asottile commented Dec 8, 2018

ok, if I check out git checkout 18835c^ in molecule I can reproduce it (even without tox-venv) -- I'm missing the lxc headers on my machine 😆

appears to happen with the develop-inst is called:

$ tox -e py27 --notest; echo $?
py27 create: /tmp/x/molecule/.tox/py27
py27 installdeps: -rrequirements.txt, -rtest-requirements.txt
py27 develop-inst: /tmp/x/molecule
ERROR: invocation failed (exit code 1), logfile: /tmp/x/molecule/.tox/py27/log/py27-2.log
ERROR: actionid: py27
msg: developpkg
cmdargs: "/tmp/x/molecule/.tox/py27/bin/python -m pip install --exists-action w -e '/tmp/x/molecule[azure,docker,gce,lxc,openstack,vagrant]'"
...

...

...

0

@webknjaz
Copy link
Contributor Author

@webknjaz webknjaz commented Dec 8, 2018

Oh.. Nice! I wasted hours on debugging because of this.
When can this be released?

@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Dec 8, 2018

we will do a release next week

@webknjaz
Copy link
Contributor Author

@webknjaz webknjaz commented Dec 13, 2018

Thanks @gaborbernat! Any specific date for release or just at some random point in time before Sunday?

@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Dec 13, 2018

python -c 'from datetime import datetime; from dateutil import tz; print(f"is {datetime.now(tz=tz.UTC)} good enough?")'                                                                                                                                                                                             
is 2018-12-13 15:24:43.090527+00:00 good enough?

see #1101

@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants